Remove once_cell dependency

Author: guilload

quickwit/CLAUDE.md

@@ -87,7 +87,7 @@ When the client is unlikely to match on an error, you can rely on the crate leve
 ### Design Patterns
 - **Trait-based services**: `SearchService`, `MetastoreService`, etc. — enables mocking and multiple implementations
 - **Feature gates**: Cloud backends (`azure`, `gcs`), message sources (`kafka`, `kinesis`, `pulsar`, `sqs`, `gcp-pubsub`), `postgres` metastore, `multilang` tokenizers
-- **Metrics**: `once_cell::sync::Lazy` statics with `quickwit_common::metrics::*` factories
+- **Metrics**: `std::sync::LazyLock` statics with `quickwit_common::metrics::*` factories
 
 ### Key Dependencies
 - **Tantivy**: Search engine library (custom fork)

quickwit/Cargo.lock

@@ -162,7 +162,6 @@ mrecordlog = { git = "https://github.com/quickwit-oss/mrecordlog", rev = "306c0a
 new_string_template = "1.5"
 nom = "8.0"
 numfmt = "1.2"
-once_cell = "1"
 oneshot = "0.1"
 openssl = { version = "0.10", default-features = false }
 openssl-probe = "0.1"

quickwit/Cargo.toml

@@ -15,7 +15,6 @@ anyhow = { workspace = true }
 async-trait = { workspace = true }
 flume = { workspace = true }
 futures = { workspace = true }
-once_cell = { workspace = true }
 serde = { workspace = true }
 serde_json = { workspace = true }
 sync_wrapper = { workspace = true }

quickwit/quickwit-actors/Cargo.toml

@@ -24,8 +24,8 @@
 
 use std::fmt;
 use std::num::NonZeroU64;
+use std::sync::LazyLock;
 
-use once_cell::sync::Lazy;
 use tokio::time::Duration;
 mod actor;
 mod actor_context;
@@ -70,7 +70,7 @@ pub use self::supervisor::{Supervisor, SupervisorMetrics, SupervisorState};
 /// If an actor does not advertise a progress within an interval of duration `HEARTBEAT`,
 /// its supervisor will consider it as blocked and will proceed to kill it, as well
 /// as all of the actors all the actors that share the killswitch.
-pub static HEARTBEAT: Lazy<Duration> = Lazy::new(heartbeat_from_env_or_default);
+pub static HEARTBEAT: LazyLock<Duration> = LazyLock::new(heartbeat_from_env_or_default);
 
 /// Returns the actor's heartbeat duration:
 /// - Derived from `QW_ACTOR_HEARTBEAT_SECS` if set and valid.

quickwit/quickwit-actors/src/lib.rs

@@ -16,7 +16,7 @@ use std::any::Any;
 use std::convert::Infallible;
 use std::fmt;
 use std::sync::atomic::{AtomicUsize, Ordering};
-use std::sync::{Arc, OnceLock, Weak};
+use std::sync::{Arc, LazyLock, Weak};
 use std::time::Instant;
 
 use quickwit_common::metrics::{GaugeGuard, IntCounter, IntGauge};
@@ -386,16 +386,15 @@ impl<A: Actor> Inbox<A> {
 }
 
 fn get_actor_inboxes_count_gauge_guard() -> GaugeGuard<'static> {
-    static INBOX_GAUGE: std::sync::OnceLock<IntGauge> = OnceLock::new();
-    let gauge = INBOX_GAUGE.get_or_init(|| {
+    static INBOX_GAUGE: LazyLock<IntGauge> = LazyLock::new(|| {
         quickwit_common::metrics::new_gauge(
             "inboxes_count",
             "overall count of actors",
             "actor",
             &[],
         )
     });
-    let mut gauge_guard = GaugeGuard::from_gauge(gauge);
+    let mut gauge_guard = GaugeGuard::from_gauge(&INBOX_GAUGE);
     gauge_guard.add(1);
     gauge_guard
 }

quickwit/quickwit-actors/src/mailbox.rs

@@ -34,7 +34,6 @@ humantime = { workspace = true }
 indicatif = { workspace = true }
 itertools = { workspace = true }
 numfmt = { workspace = true }
-once_cell = { workspace = true }
 openssl-probe = { workspace = true, optional = true }
 opentelemetry = { workspace = true }
 opentelemetry-appender-tracing = { workspace = true }

quickwit/quickwit-cli/Cargo.toml

@@ -16,7 +16,7 @@
 
 use std::collections::HashSet;
 use std::str::FromStr;
-use std::sync::OnceLock;
+use std::sync::LazyLock;
 
 use anyhow::Context;
 use clap::{Arg, ArgMatches, arg};
@@ -109,13 +109,13 @@ fn client_args() -> Vec<Arg> {
 }
 
 pub fn install_default_crypto_ring_provider() {
-    static CALL_ONLY_ONCE: OnceLock<Result<(), ()>> = OnceLock::new();
+    static CALL_ONLY_ONCE: LazyLock<Result<(), ()>> = LazyLock::new(|| {
+        rustls::crypto::ring::default_provider()
+            .install_default()
+            .map_err(|_| ())
+    });
     CALL_ONLY_ONCE
-        .get_or_init(|| {
-            rustls::crypto::ring::default_provider()
-                .install_default()
-                .map_err(|_| ())
-        })
+        .as_ref()
         .expect("rustls crypto ring default provider installation should not fail");
 }
 
@@ -348,16 +348,16 @@ fn prompt_confirmation(prompt: &str, default: bool) -> bool {
 }
 
 pub mod busy_detector {
+    use std::sync::LazyLock;
     use std::sync::atomic::{AtomicBool, AtomicU64, Ordering};
     use std::time::Instant;
 
-    use once_cell::sync::Lazy;
     use tracing::debug;
 
     use crate::metrics::CLI_METRICS;
 
     // we need that time reference to use an atomic and not a mutex for LAST_UNPARK
-    static TIME_REF: Lazy<Instant> = Lazy::new(Instant::now);
+    static TIME_REF: LazyLock<Instant> = LazyLock::new(Instant::now);
     static ENABLED: AtomicBool = AtomicBool::new(false);
 
     const ALLOWED_DELAY_MICROS: u64 = 5000;

quickwit/quickwit-cli/src/lib.rs

@@ -12,7 +12,8 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-use once_cell::sync::Lazy;
+use std::sync::LazyLock;
+
 use quickwit_common::metrics::{HistogramVec, new_histogram_vec};
 
 pub struct CliMetrics {
@@ -35,4 +36,4 @@ impl Default for CliMetrics {
 }
 
 /// Serve counters exposes a bunch a set of metrics about the request received to quickwit.
-pub static CLI_METRICS: Lazy<CliMetrics> = Lazy::new(CliMetrics::default);
+pub static CLI_METRICS: LazyLock<CliMetrics> = LazyLock::new(CliMetrics::default);

quickwit/quickwit-cli/src/metrics.rs

@@ -17,7 +17,6 @@ bytesize = { workspace = true }
 chitchat = { workspace = true }
 futures = { workspace = true }
 itertools = { workspace = true }
-once_cell = { workspace = true }
 pin-project = { workspace = true }
 rand = { workspace = true }
 serde = { workspace = true }