Skip to content

Commit a3c79c9

Browse files
PSeitz-ddPSeitz
andauthored
fix(ci): bump cross images to focal base for newer libclang (#6382)
zstd-sys 2.0.16+ pulls in bindgen 0.72 which requires libclang >= 9.0. The cross-rs 0.2.4 base is Ubuntu 16.04 (xenial, EOL) and only provides clang-3.9, causing the cross builds to panic on `clang_getTranslationUnitTargetInfo`. Move both linux-gnu cross images to the cross-rs `main` tag (Ubuntu 20.04, libclang-10), pinned by digest. Co-authored-by: Pascal Seitz <pascal.seitz@gmail.com>
1 parent 7597552 commit a3c79c9

2 files changed

Lines changed: 17 additions & 9 deletions

File tree

build/cross-images/aarch64-unknown-linux-gnu.dockerfile

Lines changed: 10 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,20 @@
1-
FROM ghcr.io/cross-rs/aarch64-unknown-linux-gnu:0.2.4@sha256:3356619b020614effd22e83cec41236e69f17ce581ffe35e252898b0c693b4e2
1+
# cross-rs hasn't cut a release after 0.2.5 (which is Ubuntu 16.04 / xenial,
2+
# whose default clang is too old for bindgen >= 0.72 used by zstd-sys >= 2.0.16).
3+
# The `main` tag tracks Ubuntu 20.04 (focal) and ships libclang-10, which
4+
# satisfies bindgen's libclang >= 9.0 requirement. Pinned by digest for
5+
# reproducibility.
6+
FROM ghcr.io/cross-rs/aarch64-unknown-linux-gnu:main@sha256:c51ec2691be5935bd08d3143994ef1b57eaf970b6ce2b723f6dea4459791bfc0
27

38
ARG PBC_URL="https://github.com/protocolbuffers/protobuf/releases/download/v21.5/protoc-21.5-linux-x86_64.zip"
49

5-
#TODO:
6-
# We can switch to static linking (remove `libsasl2-dev:arm64`) using
7-
# `rdkafka/gssapi-vendored` feature when there is a release including:
10+
#TODO:
11+
# We can switch to static linking (remove `libsasl2-dev:arm64`) using
12+
# `rdkafka/gssapi-vendored` feature when there is a release including:
813
# https://github.com/MaterializeInc/rust-sasl/pull/48
914

1015
RUN dpkg --add-architecture arm64 && \
1116
apt-get update && \
12-
apt-get install -y clang-3.9 \
13-
libclang-3.9-dev \
17+
apt-get install -y --no-install-recommends \
1418
binutils-aarch64-linux-gnu \
1519
libsasl2-dev:arm64 \
1620
unzip && \

build/cross-images/x86_64-unknown-linux-gnu.dockerfile

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,14 @@
1-
FROM ghcr.io/cross-rs/x86_64-unknown-linux-gnu:0.2.4@sha256:7c9067212c2283be2a1d5585af5ecebd4c4a2e18091e2a6aafd23f9b4b81d496
1+
# cross-rs hasn't cut a release after 0.2.5 (which is Ubuntu 16.04 / xenial,
2+
# whose default clang is too old for bindgen >= 0.72 used by zstd-sys >= 2.0.16).
3+
# The `main` tag tracks Ubuntu 20.04 (focal) and ships libclang-10, which
4+
# satisfies bindgen's libclang >= 9.0 requirement. Pinned by digest for
5+
# reproducibility.
6+
FROM ghcr.io/cross-rs/x86_64-unknown-linux-gnu:main@sha256:2431cbfcf2499f8a00570e864c5f5d3c81363dbdc23c92c9c1f9331484a44365
27

38
ARG PBC_URL="https://github.com/protocolbuffers/protobuf/releases/download/v21.5/protoc-21.5-linux-x86_64.zip"
49

510
RUN apt-get update && \
6-
apt-get install -y clang-3.9 \
7-
libclang-3.9-dev \
11+
apt-get install -y --no-install-recommends \
812
libsasl2-dev \
913
unzip && \
1014
rm -rf /var/lib/apt/lists/*

0 commit comments

Comments
 (0)