Fix clippy warnings

- Replace .increment() with .inc_by() on LazyCounter call sites in
  azure_blob_storage and opendal_storage.
- Derive Default for TelemetryHandle instead of manual impl.
- Auto-fix minor clippy lints in metastore, tower metrics, and
  split_table.

Co-authored-by: Cursor <cursoragent@cursor.com>

Author: Mallets

quickwit/quickwit-common/src/tower/metrics.rs

@@ -151,8 +151,7 @@ impl<F> PinnedDrop for ResponseFuture<F> {
 }
 
 impl<F, T, E> Future for ResponseFuture<F>
-where
-    F: Future<Output = Result<T, E>>,
+where F: Future<Output = Result<T, E>>
 {
     type Output = Result<T, E>;
 

quickwit/quickwit-metastore/src/metastore/postgres/metrics.rs

@@ -12,9 +12,7 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-use std::sync::LazyLock;
-
-use quickwit_metrics::{Gauge, LazyGauge, gauge, lazy_gauge};
+use quickwit_metrics::{LazyGauge, lazy_gauge};
 
 pub(super) static ACQUIRE_CONNECTIONS: LazyGauge = lazy_gauge!(
         name: "acquire_connections",

quickwit/quickwit-storage/src/object_storage/azure_blob_storage.rs

@@ -241,7 +241,7 @@ impl AzureBlobStorage {
         payload: Box<dyn crate::PutPayload>,
     ) -> StorageResult<()> {
         crate::metrics::OBJECT_STORAGE_PUT_PARTS.inc();
-        crate::metrics::OBJECT_STORAGE_UPLOAD_NUM_BYTES.increment(payload.len());
+        crate::metrics::OBJECT_STORAGE_UPLOAD_NUM_BYTES.inc_by(payload.len());
         retry(&self.retry_params, || async {
             let data = Bytes::from(payload.read_all().await?.to_vec());
             let hash = azure_storage_blobs::prelude::Hash::from(md5::compute(&data[..]).0);
@@ -275,7 +275,7 @@ impl AzureBlobStorage {
                 let moved_blob_client = blob_client.clone();
                 let moved_payload = payload.clone();
                 crate::metrics::OBJECT_STORAGE_PUT_PARTS.inc();
-                crate::metrics::OBJECT_STORAGE_UPLOAD_NUM_BYTES.increment(range.end - range.start);
+                crate::metrics::OBJECT_STORAGE_UPLOAD_NUM_BYTES.inc_by(range.end - range.start);
                 async move {
                     retry(&self.retry_params, || async {
                         // zero pad block ids to make them sortable as strings
@@ -372,7 +372,7 @@ impl Storage for AzureBlobStorage {
                 .compat();
             let mut body_stream_reader = BufReader::new(chunk_response_body_stream);
             let num_bytes_copied = tokio::io::copy_buf(&mut body_stream_reader, output).await?;
-            crate::metrics::OBJECT_STORAGE_DOWNLOAD_NUM_BYTES.increment(num_bytes_copied);
+            crate::metrics::OBJECT_STORAGE_DOWNLOAD_NUM_BYTES.inc_by(num_bytes_copied);
         }
         output.flush().await?;
         Ok(())
@@ -571,7 +571,7 @@ async fn download_all(
             segments.push(bytes);
         }
     }
-    crate::metrics::OBJECT_STORAGE_DOWNLOAD_NUM_BYTES.increment(total_num_bytes as u64);
+    crate::metrics::OBJECT_STORAGE_DOWNLOAD_NUM_BYTES.inc_by(total_num_bytes as u64);
     Ok(coalesce_segments(segments, total_num_bytes))
 }
 

quickwit/quickwit-storage/src/opendal_storage/base.rs

@@ -94,7 +94,7 @@ impl Storage for OpendalStorage {
             .compat_write();
         tokio::io::copy(&mut payload_reader, &mut storage_writer).await?;
         storage_writer.get_mut().close().await?;
-        crate::metrics::OBJECT_STORAGE_UPLOAD_NUM_BYTES.increment(payload.len());
+        crate::metrics::OBJECT_STORAGE_UPLOAD_NUM_BYTES.inc_by(payload.len());
         Ok(())
     }
 
@@ -108,7 +108,7 @@ impl Storage for OpendalStorage {
             .await?
             .compat();
         let num_bytes_copied = tokio::io::copy(&mut storage_reader, output).await?;
-        crate::metrics::OBJECT_STORAGE_DOWNLOAD_NUM_BYTES.increment(num_bytes_copied);
+        crate::metrics::OBJECT_STORAGE_DOWNLOAD_NUM_BYTES.inc_by(num_bytes_copied);
         output.flush().await?;
         Ok(())
     }

quickwit/quickwit-storage/src/split_cache/split_table.rs

@@ -154,10 +154,7 @@ impl SplitTable {
             Status::Downloading { .. } => &mut self.downloading_splits,
             Status::OnDisk { num_bytes } => {
                 self.on_disk_bytes -= num_bytes;
-                SEARCHER_SPLIT_CACHE
-                    .cache_metrics
-                    .in_cache_count
-                    .dec();
+                SEARCHER_SPLIT_CACHE.cache_metrics.in_cache_count.dec();
                 SEARCHER_SPLIT_CACHE
                     .cache_metrics
                     .in_cache_num_bytes

quickwit/quickwit-telemetry-exporters/src/lib.rs

@@ -41,22 +41,13 @@ pub fn do_nothing_env_filter_reload_fn() -> EnvFilterReloadFn {
     Arc::new(|_| Ok(()))
 }
 
+#[derive(Default)]
 pub struct TelemetryHandle {
     tracer_provider: Option<SdkTracerProvider>,
     logger_provider: Option<SdkLoggerProvider>,
     meter_provider: Option<SdkMetricsProvider>,
 }
 
-impl Default for TelemetryHandle {
-    fn default() -> Self {
-        TelemetryHandle {
-            tracer_provider: None,
-            logger_provider: None,
-            meter_provider: None,
-        }
-    }
-}
-
 impl TelemetryHandle {
     pub fn shutdown(self) -> anyhow::Result<()> {
         if let Some(tracer_provider) = self.tracer_provider {