Commit ebc1b66
feat: Phase 3d+3e — ParquetMergePipeline supervisor + publisher feedback (#6354)
* feat: add ParquetMergePipeline supervisor and publisher feedback (Phase 3d+3e)
Phase 3 pipeline integration, combined supervisor and feedback PR:
- ParquetMergePipeline supervisor: spawns all merge actors (publisher →
sequencer → uploader → executor → downloader → planner), health-checks
with periodic supervision loop, respawn on failure with backoff,
graceful shutdown via FinishPendingMergesAndShutdownPipeline that
disconnects feedback and runs finalize policy. 3 tests.
- Publisher feedback: add parquet_merge_planner_mailbox_opt to Publisher
(feature-gated behind cfg(feature = "metrics")). After successful
ParquetSplitsUpdate publish of new ingested splits, sends ParquetNewSplits
to the planner. Merge outputs (non-empty replaced_split_ids) are not
fed back to avoid infinite loops.
- DisconnectMergePlanner extended to clear both Tantivy and Parquet planner
mailboxes, supporting shutdown drain for both pipeline types.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
* fix: nightly rustfmt import ordering in parquet_merge_pipeline
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
* fix: reflow comment to satisfy nightly rustfmt wrap_comments
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
* fix: feed back merge outputs to planner, matching Tantivy behavior
The guard that filtered out merge outputs (non-empty replaced_split_ids)
from the feedback loop was incorrect. Tantivy feeds ALL new splits to
the merge planner — both ingest and merge outputs. Infinite loops are
prevented by the merge policy's maturity checks (max_merge_ops, size,
maturation_period), not by the publisher.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>1 parent 7b352cd commit ebc1b66
5 files changed
Lines changed: 662 additions & 0 deletions
File tree
- quickwit/quickwit-indexing/src/actors
- metrics_pipeline
Lines changed: 8 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
39 | 39 | | |
40 | 40 | | |
41 | 41 | | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
42 | 46 | | |
43 | 47 | | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
44 | 52 | | |
45 | 53 | | |
46 | 54 | | |
| |||
Lines changed: 2 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
27 | 27 | | |
28 | 28 | | |
29 | 29 | | |
| 30 | + | |
30 | 31 | | |
31 | 32 | | |
32 | 33 | | |
| |||
50 | 51 | | |
51 | 52 | | |
52 | 53 | | |
| 54 | + | |
53 | 55 | | |
54 | 56 | | |
55 | 57 | | |
| |||
0 commit comments