Zone Map Pruning for Metrics#6363
Open
alexanderbianchi wants to merge 1 commit intomainfrom
Open
Conversation
cdd27b7 to
910756a
Compare
Collaborator
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. 🎉 ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
910756a to
f2b6096
Compare
f2b6096 to
93bcde4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
INpredicates from DataFusion filters and evaluates them against split metadata before building Parquet file groups.LIKEpredicates such ashost LIKE 'ID-07%'for metrics tag metadata pruning.metric_namemetadata, exact low-cardinality tag metadata, and per-columnzonemap_regexeswhen present.LIKEagainst zonemap regexes as a regex-language prefix intersection, not by matching the prefix string itself, so values likeID-0701satisfyID-07%.LIKE, as inexact pushdown so DataFusion passes them into theTableProviderscan while still applying the row-level filter later.LIKEzonemap pruning.Notes
This intentionally does not push tag predicates into the metastore query yet. Metric name and time range still drive metastore-side pruning; tag and zonemap pruning runs locally on returned split metadata before Parquet files are read.
Prefix
LIKEsupport is deliberately narrow: only literal trailing-percent patterns are extracted, for examplehost LIKE 'ID-07%'. More generalLIKEpatterns, escaped wildcards, negatedLIKE, andILIKEremain row-level filters.Testing
cargo fmt --package quickwit-datafusioncargo test -p quickwit-datafusion