Add IO metrics#6429
Merged
Merged
Conversation
guilload
force-pushed
the
guilload/io-metrics
branch
3 times, most recently
from
66ce695 to
e327f28
Compare
guilload
force-pushed
the
guilload/io-metrics
branch
2 times, most recently
from
fc1c4ca to
12fc7c0
Compare
| impl Default for IoMetrics { | ||
| fn default() -> Self { | ||
| Self { | ||
| read_bytes_total: new_counter( |
Collaborator
There was a problem hiding this comment.
We're doing inc_by with deltas, but the names are _total - we should probably omit total.
| let span = info_span!("mrecordlog.truncate", queue, position); | ||
| let queue = queue.to_string(); | ||
| self.run_operation(span, move |mrecordlog| { | ||
| mrecordlog.truncate(&queue, position) |
Collaborator
There was a problem hiding this comment.
why deos this change work? one passes a u64 and the other passes a RangeInclusive? Is there some magical promotion that takes place somewhere?
Member
Author
There was a problem hiding this comment.
The API of mrecordlog has changed.
nadav-govari
approved these changes
May 19, 2026
Collaborator
nadav-govari
left a comment
nadav-govari
left a comment
There was a problem hiding this comment.
You have some merge conflicts
guilload
force-pushed
the
guilload/io-metrics
branch
3 times, most recently
from
cdf9501 to
00f45eb
Compare
guilload
force-pushed
the
guilload/io-metrics
branch
from
00f45eb to
aaa2d08
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Keep track of bytes written in the WAL and add process level metrics.
How was this PR tested?
Tested on benchmark machine