Option to preserve file mtime on save #645
Open
kjc1 wants to merge 6 commits into
Open
Conversation
Member
|
What's the use case for this? Any why does it have to be part of mutagen? |
Collaborator
|
I also think this should be part of an application using mutagen, not mutagen itself. Mutagen should stick to the low level functionality. I see several issues here
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Provides support to all file formats to preserve the original file mtime on save. I'm aware some users already implement this functionality outside of Mutagen (e.g. Picard) so this has been implemented as an optional flag on the save method where the default (false) maintains the current behaviour.
I have a separate PR incoming to utilise this in Quod Libet.