Add support for ID_MD5_CHECKSUM in WavPack files#680
Open
audiomuze wants to merge 1 commit into
Open
Conversation
audiomuze
changed the title
Collaborator
|
Hi. The changes for the WavPack checksum is not part of this PR, missed a commit? We could change this PR back to the original title and just merge the CI changes now, and you do another PR with the checksum feature?
Yes, I think it was never officially part of the API. But if it behaves similar in the two implementations than I seen no reason not to expose this. This is clearly meta information some software wants to read. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for retrieving the ID_MD5_CHECKSUM in WavPack files, much like retrieving the md5 for FLAC is supported (albeit for some reason no longer documented).