Fix ROI conversion from instance segmentation mask#42
Merged
Conversation
This commit fixes two issues: 1. Corrects the ROI orientation for the instance segmentation masks. 2. Handles the case where Mask is size of full Image vs a fixed size masked returned by Mask-RCNN instance segmentation models.
Member
|
Thanks, can you provide any specific examples of models and code that shows that this works? |
Contributor
Author
Contributor
Author
Contributor
Author
|
While this seems to address the issue with the orientation and scaling, things to consider:
Let me know your thoughts. |
Member
|
Thanks, the changes look good to me! |
petebankhead
added a commit
to petebankhead/qupath
that referenced
this pull request
Nov 11, 2025
To get this fix qupath/qupath-extension-djl#42
Contributor
Author
|
Thanks pete, I can also add an example of instance segmentation to the docs. I just finished setting up local repo and a python environment for the qupath-docs, please let me know. |
ajay1685
added a commit
to ajay1685/qupath-docs
that referenced
this pull request
Feb 19, 2026
Instance segmentation models are available in QuPath. Refer to qupath/qupath-extension-djl#42
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



This commit fixes two issues:
I created an issue: #41