Error if recursively reloading (#2639)

Fixes #2617. Also fixes #2556, since we need to import `is_loading()` in order to mock it.

Author: hadley

NAMESPACE

@@ -47,6 +47,7 @@ export(install_svn)
 export(install_url)
 export(install_version)
 export(is.package)
+export(is_loading)
 export(lint)
 export(load_all)
 export(loaded_packages)
@@ -90,6 +91,7 @@ importFrom(pkgbuild,find_rtools)
 importFrom(pkgbuild,has_devel)
 importFrom(pkgbuild,with_debug)
 importFrom(pkgload,check_dep_version)
+importFrom(pkgload,is_loading)
 importFrom(pkgload,parse_deps)
 importFrom(pkgload,unload)
 importFrom(remotes,dev_package_deps)

NEWS.md

@@ -1,5 +1,8 @@
 # devtools (development version)
 
+* `is_loading()` is now re-exported from pkgload (#2556).
+* `load_all()` now errors if called recursively, i.e. if you accidentally include a `load_all()` call in one of your R source files (#2617).
+
 # devtools 2.4.6
 
 * Functions that use httr now explicitly check that it is installed

R/pkgload.R

@@ -14,6 +14,13 @@ load_all <- function(
     path <- path$path
   }
 
+  if (is_loading()) {
+    cli::cli_abort(c(
+      "Recursive loading detected.",
+      i = "Did you accidentally include {.fn load_all} in an R source file?"
+    ))
+  }
+
   save_all()
 
   check_dots_used(action = getOption("devtools.ellipsis_action", rlang::warn))
@@ -29,6 +36,10 @@ load_all <- function(
   )
 }
 
+#' @importFrom pkgload is_loading
+#' @export
+pkgload::is_loading
+
 #' @importFrom pkgload unload
 #' @export
 pkgload::unload

man/reexports.Rd

@@ -0,0 +1,9 @@
+# load_all() errors if called recursively
+
+    Code
+      load_all()
+    Condition
+      Error in `load_all()`:
+      ! Recursive loading detected.
+      i Did you accidentally include `load_all()` in an R source file?
+

tests/testthat/_snaps/pkgload.md

@@ -0,0 +1,4 @@
+test_that("load_all() errors if called recursively", {
+  local_mocked_bindings(is_loading = function() TRUE)
+  expect_snapshot(load_all(), error = TRUE)
+})