Deprecate install_*() functions#2649
Merged
Merged
Conversation
Member
|
What do you think of moving remotes to Suggests? (And making the necessary changes to this PR.) |
Member
Author
|
Yeah, I like it. |
Member
|
We discussed in slack and it makes more sense to attempt moving remotes from Imports to Suggests once the current bolus of PRs lands. Opened #2663 to track. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2571
@jennybc there were no existing tests of these install functions, so no easy way to add snapshot tests for the deprecation messages. So when reviewing I'd suggest reading the new docs (
?"install-deprecated")and then trying out a couple of functions to check the messages look ok.