Skip to content

Commit b6482ef

Browse files
authored
resps_*() improvements (#819)
* Proofread docs (fixes #808) * Export `resps_ok()` (fixes #807)
1 parent 6f984b1 commit b6482ef

5 files changed

Lines changed: 18 additions & 8 deletions

File tree

.claude/settings.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@
99
"Edit(R/**)",
1010
"Edit(tests/**)",
1111
"Edit(vignettes/**)",
12+
"Edit(NEWS.md)"
1213
],
1314
"deny": []
1415
}

NAMESPACE

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -148,6 +148,7 @@ export(response)
148148
export(response_json)
149149
export(resps_data)
150150
export(resps_failures)
151+
export(resps_ok)
151152
export(resps_requests)
152153
export(resps_successes)
153154
export(secret_decrypt)

NEWS.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
# httr2 (development version)
22

3+
* New `resps_ok()` returns a logical vector indicating which requests were successful (#807).
34
* httr2 will now emit OpenTelemetry traces for all requests when tracing is enabled. Requires the `otelsdk` package (@atheriel, #729).
45
* `req_perform_connection()` no longer errors with `no applicable method for 'close' applied to an object of class "c('httr2_failure', 'httr2_error', 'rlang_error', 'error', 'condition')` (#817).
56
* Refactor `url_modify()` to better retain exact formatting of URL components

R/iterate-responses.R

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,17 @@
11
#' Tools for working with lists of responses
22
#'
33
#' @description
4-
#' These functions provide a basic toolkit for operating with lists of
4+
#' These functions provide a basic toolkit for working with lists of
55
#' responses and possibly errors, as returned by [req_perform_parallel()],
6-
#' [req_perform_sequential()] and [req_perform_iterative()].
6+
#' [req_perform_sequential()], and [req_perform_iterative()].
77
#'
88
#' * `resps_successes()` returns a list of successful responses.
99
#' * `resps_failures()` returns a list of failed responses (i.e. errors).
10+
#' * `resps_ok()` returns a logical vector indicating which requests were
11+
#' successful.
1012
#' * `resps_requests()` returns the list of requests that corresponds to
11-
#' each request.
13+
#' each response.
1214
#' * `resps_data()` returns all the data in a single vector or data frame.
13-
#' It requires the vctrs package to be installed.
1415
#'
1516
#' @export
1617
#' @param resps A list of responses (possibly including errors).
@@ -52,6 +53,8 @@ resps_failures <- function(resps) {
5253
resps[!resps_ok(resps)]
5354
}
5455

56+
#' @export
57+
#' @rdname resps_successes
5558
resps_ok <- function(resps) {
5659
vapply(resps, is_response, logical(1))
5760
}

man/resps_successes.Rd

Lines changed: 8 additions & 4 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)