-
Notifications
You must be signed in to change notification settings - Fork 85
Expose request timing #735
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
488db71
Expose request timing
arcresu e21b407
Link to upstream curl documentation
arcresu 2de29c0
Improve resp_timing docs
arcresu ffe6b32
Merged origin/main into arcresu-req-timing
hadley f9d3ad5
Partition test into setting and getting
hadley 7a9175e
Fix docs
hadley File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| #' Extract timing data | ||
| #' | ||
| #' The underlying curl library measures how long different components of the | ||
| #' request take to complete. This function retrieves that information. | ||
| #' | ||
| #' @inheritParams resp_header | ||
| #' @returns Named numeric vector of timing information. | ||
| #' The names of the elements in this vector correspond to the names used | ||
| #' in [libcurl's `curl_easy_getinfo()` API][curl docs]. | ||
| #' The most useful component is likely `"total"` (corresponding to | ||
| #' `CURLINFO_TOTAL_TIME`), the overall time in seconds to complete the | ||
| #' request including any redirects followed. | ||
| #' | ||
| #' [curl docs]: https://curl.se/libcurl/c/curl_easy_getinfo.html | ||
| #' @export | ||
| #' @examples | ||
| #' req <- request(example_url()) | ||
| #' resp <- req_perform(req) | ||
| #' resp_timing(resp) | ||
| resp_timing <- function(resp) { | ||
| check_response(resp) | ||
|
|
||
| resp$timing | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| test_that("can extract request timing", { | ||
| req <- response(timing = c(total = 1)) | ||
| expect_equal(resp_timing(req), c(total = 1)) | ||
| }) | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@arcresu I figured it was easier to just make the change than try to explain it further. And now that I've done it, I can express what I was picking up on more clearly: it's worth partitioning your test into two pieces, one that tests we are correctly setting the values, and one that tests we are correctly getting the values.