Skip to content

create_response() already sets the last response #736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hadley merged 1 commit into from
Jun 13, 2025
+2 −5
Merged

create_response() already sets the last response #736

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions R/req-perform-connection.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,9 +140,7 @@
}

curl_data <- curl::handle_data(handle)

the$last_response <- create_response(req, curl_data, body)
the$last_response
create_response(req, curl_data, body)

Check warning on line 143 in R/req-perform-connection.R

View check run for this annotation

Codecov / codecov/patch

R/req-perform-connection.R#L143 

Added line #L143 was not covered by tests
}

# Make open mockable
Expand Down
3 changes: 1 addition & 2 deletions R/req-perform.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,8 +190,7 @@ req_perform1 <- function(req, path = NULL, handle = NULL) {
curl::handle_setopt(handle, cookielist = "FLUSH")
curl::handle_setopt(handle, cookiefile = NULL, cookiejar = NULL)

the$last_response <- create_response(req, fetch$curl_data, fetch$body)
the$last_response
create_response(req, fetch$curl_data, fetch$body)
}

curl_fetch <- function(handle, url, path) {
Expand Down
Loading