Use curl to modify/construct urls#741
Merged
Merged
Conversation
Note that `req_url_path_append()` now only actually affects the path, not other components of the URL like the query params. Fixes #732
Member
Author
|
The revdeps seems to be mostly something to do with httptest2, so I should figure that out first. But I only see one very obvious failure related to this change, and that's atrrr. |
Member
Author
|
And a couple of failures due to the case of the encoded characters changing. |
Member
Author
|
Oooh actually the httptest2 failures might be because of that case change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note that
req_url_path_append()now only actually affects the path, not other components of the URL like the query params.To do:
Fixes #732