Remove menu_separator before the first navbar item#3001
Open
DanChaltiel wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
This is a very minor PR to fix a very minor bug.
When the "Articles" navbar menu has sections, a separator is added before the section.
However, for the first section, this doesn't look very nice, as you can see for example on https://roxygen2.r-lib.org/:
The PR simply checks that the index is not 1.
Since the second argument of
imap()was namedindexI used it, but maybepurrr::map2(navbar, seq_along(navbar), ...)would be more robust, as this might break in the case wherenavbarhas names. I'm not familiar enough with the API to know if this can happen.