Tweak R6 usage#1815
Conversation
* Use `obj$method()` not `{classname}$method()`
* Use `{classname}()` not `{classname}$new()`
* `rd_r6_method()` no longer needs alias
Fixes #1026
| if (method == "initialize") { | ||
| class | ||
| } else { | ||
| paste0("obj$", method) |
There was a problem hiding this comment.
I know <class>$method is not technically correct, but it is more informative than the constant obj$ prefix.
There was a problem hiding this comment.
Because then it's confusing that Foo$new() literally means to call Foo$new(), but Foo$something_else() does not.
There was a problem hiding this comment.
Good point. Is Foo_object$method() too long? How about adding a call that actually creates an object? Something like this?
Foo_object <- Foo$new(...)
Foo_object$method1()
...
There was a problem hiding this comment.
Those both feel a bit long to me.
There was a problem hiding this comment.
We could just do $method()? Or is that too confusing?
There was a problem hiding this comment.
$method is not valid R code.
There was a problem hiding this comment.
How about
o <- Foo$new(...)
o$method1()
...
?
|
Here's a concrete example to consider: 
It seems bad that we show the method in three different ways: |
|
Overall, I think I like this approach, but it does feel a bit repetitive for simple methods: 
|
2 participants
Consistently refer to methods in the same way in every location.
Fixes #1258