Correct {cli} markup for informative failure (#2296)

Author: MichaelChirico

NEWS.md

@@ -1,5 +1,6 @@
 # testthat 3.3.1
 
+* `expect_snapshot_file()` correctly reports file name if duplicated (@MichaelChirico, #2296).
 * Fixed support for `shinytest2::AppDriver$expect_values()` screenshot snapshot failing on CI (#2293, #2288).
 
 * testthat now emits OpenTelemetry traces for tests when tracing is enabled. Requires the otel and otelsdk packages (#2282).

R/snapshot-reporter.R

@@ -135,7 +135,7 @@ SnapshotReporter <- R6::R6Class(
       save_path <- paste0(c(self$file, variant, name), collapse = "/")
       if (save_path %in% self$snap_file_saved) {
         cli::cli_abort(
-          "Snapshot file names must be unique. {.arg name} has already been used.",
+          "Snapshot file names must be unique. {.val {name}} has already been used.",
           call = trace_env
         )
       }

tests/testthat/_snaps/snapshot-file.md

@@ -4,7 +4,7 @@
       expect_snapshot_file(write_tmp_lines(r_version()), "version.txt", variant = r_version())
     Condition
       Error in `expect_snapshot_file()`:
-      ! Snapshot file names must be unique. `name` has already been used.
+      ! Snapshot file names must be unique. "version.txt" has already been used.
 
 # warns on first creation