Skip to content

Always report success/failure count#2298

Merged
hadley merged 4 commits into
r-lib:mainfrom
MichaelChirico:patch-10
Jan 7, 2026
Merged

Always report success/failure count#2298
hadley merged 4 commits into
r-lib:mainfrom
MichaelChirico:patch-10

Conversation

@MichaelChirico
Copy link
Copy Markdown
Contributor

Closes #2297

Initial proposal

@hadley
Copy link
Copy Markdown
Member

hadley commented Nov 26, 2025

Hmmm, the intent was to report exactly what the problem was, which your change loses. I wonder if we could do something with the bullets?

Expected 1 success and 0 failures
✅ Observed 1 success
❌ Observed 1 failure

See expect_match() for existing art in this direction.

@hadley
Copy link
Copy Markdown
Member

hadley commented Jan 7, 2026

@MichaelChirico how does this look to you?

Copy link
Copy Markdown
Contributor Author

@MichaelChirico MichaelChirico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent! LGTM

@hadley hadley merged commit ceeadda into r-lib:main Jan 7, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

expect_failure() should report that the correct number of failures was indeed observed

2 participants