Skip to content

Polish snapshot_download_gh()#2306

Merged
hadley merged 2 commits into
mainfrom
snapshot-download-polish
Jan 7, 2026
Merged

Polish snapshot_download_gh()#2306
hadley merged 2 commits into
mainfrom
snapshot-download-polish

Conversation

@hadley
Copy link
Copy Markdown
Member

@hadley hadley commented Jan 6, 2026

  • Clarify meaning of dest_dir.
  • Only emit hint in R-CMD-check jobs.

Fixes #2300

@claude
Copy link
Copy Markdown

claude Bot commented Jan 6, 2026

Claude finished @hadley's task —— View job


Code Review

  • Read repository guidelines (CLAUDE.md)
  • Review changed files for bugs and issues
  • Provide feedback

Review Summary

I've reviewed the changes in this PR which polish snapshot_download_gh(). The changes are minimal and focused on two specific improvements:

  1. Documentation clarification: The dest_dir parameter documentation was updated from "Defaults to the current directory" to "Package root directory. Defaults to the current directory" - this clarifies the expected structure.

  2. Conditional hint emission: The snapshot hint is now only emitted when GITHUB_JOB == "R-CMD-check" (line 126 in R/reporter-check.R), which prevents noise in other CI jobs.

Both changes are sensible improvements with no apparent bugs or issues. The test coverage validates the new conditional behavior.

LGTM

@hadley hadley merged commit 75990de into main Jan 7, 2026
14 checks passed
@hadley hadley deleted the snapshot-download-polish branch January 7, 2026 02:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

gh_download_artifact(): "Unexpected artifact format." from covr_trace

1 participant