Merge pull request #61 from ra1028/swiftlint

Add SwiftLint config and run before compiling

Author: ra1028

.hound.yml

@@ -0,0 +1,2 @@
+swiftlint:
+  config_file: .swiftlint.yml

.swiftlint.yml

@@ -0,0 +1,31 @@
+# https://github.com/realm/SwiftLint
+
+excluded:
+  - Tests/XCTestManifests.swift
+
+disabled_rules:
+  - type_name
+  - identifier_name
+  - force_cast
+  - xctfail_message
+  - function_body_length
+  - file_length
+
+nesting:
+  type_level:
+    warning: 2
+
+line_length:
+  warning: 200
+
+type_body_length:
+  warning: 400
+
+function_parameter_count:
+  warning: 8
+
+cyclomatic_complexity:
+  warning: 12
+
+statement_position:
+  statement_mode: uncuddled_else

DifferenceKit.xcodeproj/project.pbxproj

@@ -179,6 +179,7 @@
 				6B2DF86A210E2C12004D2D40 /* Frameworks */,
 				6B2DF86B210E2C12004D2D40 /* Headers */,
 				6B2DF86C210E2C12004D2D40 /* Resources */,
+				6B7EEDA4224E5A5000060872 /* SwiftLint */,
 			);
 			buildRules = (
 			);
@@ -263,6 +264,27 @@
 		};
 /* End PBXResourcesBuildPhase section */
 
+/* Begin PBXShellScriptBuildPhase section */
+		6B7EEDA4224E5A5000060872 /* SwiftLint */ = {
+			isa = PBXShellScriptBuildPhase;
+			buildActionMask = 2147483647;
+			files = (
+			);
+			inputFileListPaths = (
+			);
+			inputPaths = (
+			);
+			name = SwiftLint;
+			outputFileListPaths = (
+			);
+			outputPaths = (
+			);
+			runOnlyForDeploymentPostprocessing = 0;
+			shellPath = /bin/sh;
+			shellScript = "if which swiftlint >/dev/null; then\nswiftlint\nelse\necho \"warning: SwiftLint not installed, download from https://github.com/realm/SwiftLint\"\nfi\n";
+		};
+/* End PBXShellScriptBuildPhase section */
+
 /* Begin PBXSourcesBuildPhase section */
 		6B2DF869210E2C12004D2D40 /* Sources */ = {
 			isa = PBXSourcesBuildPhase;

Examples/Example-macOS/Sources/ShuffleEmoticonViewController.swift

@@ -4,7 +4,7 @@ import DifferenceKit
 final class ShuffleEmoticonViewController: NSViewController {
     @IBOutlet private weak var collectionView: NSCollectionView!
     @IBOutlet private weak var tableView: NSTableView!
-    
+
     private var data = (0x1F600...0x1F647).compactMap { UnicodeScalar($0).map(String.init) }
     private var dataInput: [String] {
         get { return data }
@@ -22,7 +22,7 @@ final class ShuffleEmoticonViewController: NSViewController {
     @IBAction func shufflePress(_ button: NSButton) {
         dataInput.shuffle()
     }
-    
+
     override func awakeFromNib() {
         super.awakeFromNib()
 
@@ -34,11 +34,11 @@ extension ShuffleEmoticonViewController: NSCollectionViewDataSource {
     func numberOfSections(in collectionView: NSCollectionView) -> Int {
         return 1
     }
-    
+
     func collectionView(_ collectionView: NSCollectionView, numberOfItemsInSection section: Int) -> Int {
         return data.count
     }
-    
+
     func collectionView(_ collectionView: NSCollectionView, itemForRepresentedObjectAt indexPath: IndexPath) -> NSCollectionViewItem {
         let item = collectionView.makeItem(withIdentifier: EmoticonCollectionViewItem.itemIdentifier, for: indexPath) as! EmoticonCollectionViewItem
         item.emoticon = data[indexPath.item]
@@ -50,7 +50,7 @@ extension ShuffleEmoticonViewController: NSTableViewDataSource, NSTableViewDeleg
     func numberOfRows(in tableView: NSTableView) -> Int {
         return data.count
     }
-    
+
     func tableView(_ tableView: NSTableView, viewFor tableColumn: NSTableColumn?, row: Int) -> NSView? {
         let view = tableView.makeView(withIdentifier: NSTableCellView.itemIdentifier, owner: tableView) as! NSTableCellView
         view.textField?.stringValue = data[row]

Package.swift

@@ -19,4 +19,4 @@ let package = Package(
             path: "Tests"
         )
     ]
-)
+)

Sources/Algorithm.swift

@@ -1,3 +1,5 @@
+// swiftlint:disable cyclomatic_complexity
+
 public extension StagedChangeset where Collection: RangeReplaceableCollection, Collection.Element: Differentiable {
     /// Creates a new `StagedChangeset` from the two collections.
     ///

Sources/Extensions/UIKitExtension.swift

@@ -115,7 +115,8 @@ public extension UITableView {
     private func _performBatchUpdates(_ updates: () -> Void) {
         if #available(iOS 11.0, tvOS 11.0, *) {
             performBatchUpdates(updates)
-        } else {
+        }
+        else {
             beginUpdates()
             updates()
             endUpdates()

Tests/AlgorithmTest.swift

@@ -188,7 +188,7 @@ extension AlgorithmTestCase {
             M(2, false),
             M(4, false),
             M(0, true),
-            M(3, false),
+            M(3, false)
         ]
 
         XCTAssertExactDifferences(
@@ -320,7 +320,7 @@ extension AlgorithmTestCase {
         let source2 = [ArraySection<D, Int>]()
 
         let target2 = [
-            ArraySection(model: D.a, elements: [0]),
+            ArraySection(model: D.a, elements: [0])
         ]
 
         XCTAssertExactDifferences(
@@ -674,12 +674,12 @@ extension AlgorithmTestCase {
     func testComplicated8() {
         let source = [
             ArraySection(model: M(0, false), elements: [M(0, false), M(1, false)]),
-            ArraySection(model: M(1, false), elements: [M(2, false), M(3, false)]),
+            ArraySection(model: M(1, false), elements: [M(2, false), M(3, false)])
         ]
 
         let target = [
             ArraySection(model: M(0, false), elements: []),
-            ArraySection(model: M(1, false), elements: [M(1, true), M(3, false)]),
+            ArraySection(model: M(1, false), elements: [M(1, true), M(3, false)])
         ]
 
         XCTAssertReproducible(source: source, target: target)

Tests/TestTools.swift

@@ -182,7 +182,8 @@ func XCTAssertReproducible<C: RangeReplaceableCollection & Equatable>(
         let targetElementPath: ElementPath
         if let movedTargetElementPath = elementMoveMap[sourceElementPath] {
             targetElementPath = movedTargetElementPath
-        } else {
+        }
+        else {
             let deleteOffset = elementDeletionMap[sourceElementPath.section].count(in: 0..<sourceElementPath.element)
             let insertOffset = elementInsertionMap[sourceElementPath.section].count(in: 0...sourceElementPath.element)
             targetElementPath = ElementPath(element: sourceElementPath.element - deleteOffset + insertOffset, section: sourceElementPath.section)