Skip to content

Commit ca5a624

Browse files
authored
Merge pull request #62 from ra1028/guideline_files
Add guideline files
2 parents 157bae8 + c4cc244 commit ca5a624

27 files changed

Lines changed: 324 additions & 39 deletions
Lines changed: 42 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,42 @@
1+
---
2+
name: Bug Report
3+
about: Create a bug report.
4+
---
5+
6+
## Checklist
7+
- [ ] This is not a Apple's bug.
8+
- [ ] Reviewed the [README](https://github.com/ra1028/DifferenceKit/blob/master/README.md) and [documents](https://ra1028.github.io/DifferenceKit).
9+
- [ ] Searched [existing issues](https://github.com/ra1028/DifferenceKit/issues) for ensure not duplicated.
10+
11+
## Expected Behavior
12+
<!--- Tell us what should happen -->
13+
14+
## Current Behavior
15+
<!--- Tell us what happens instead of the expected behavior -->
16+
17+
## Steps to Reproduce
18+
<!--- Provide a link to a live example, or an unambiguous set of steps to -->
19+
<!--- reproduce this bug. Include code to reproduce, if relevant -->
20+
1.
21+
2.
22+
3.
23+
4.
24+
25+
## Detailed Description (Include Screenshots)
26+
<!--- Provide a detailed description of the bug -->
27+
28+
## Reproducible Demo Project
29+
<!--- If you have, provide links of bug reproducible project that we can refer -->
30+
31+
## Environments
32+
- Library version:
33+
34+
- Swift version:
35+
36+
- iOS version:
37+
38+
- Xcode version:
39+
40+
- Devices/Simulators:
41+
42+
- CocoaPods/Carthage version:
Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,18 @@
1+
---
2+
name: Feature Request
3+
about: Create a feature request.
4+
---
5+
6+
## Checklist
7+
- [ ] Reviewed the [README](https://github.com/ra1028/DifferenceKit/blob/master/README.md) and [documents](https://ra1028.github.io/DifferenceKit).
8+
- [ ] Searched [existing issues](https://github.com/ra1028/DifferenceKit/issues) for ensure not duplicated.
9+
10+
## Description
11+
<!--- Provide a detailed description of the feature you are proposing -->
12+
13+
## Motivation and Context
14+
<!--- Why is this feature required? What problem does it solve? -->
15+
<!--- If it fixes an open issue, please link to the issue here. -->
16+
17+
## Proposed Solution
18+
<!--- Describe the solution you proposing. -->

.github/ISSUE_TEMPLATE/QUESTION.md

Lines changed: 30 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,30 @@
1+
---
2+
name: Question
3+
about: Create a bug question.
4+
---
5+
6+
## Checklist
7+
- [ ] Reviewed the [README](https://github.com/ra1028/DifferenceKit/blob/master/README.md) and [documents](https://ra1028.github.io/DifferenceKit).
8+
- [ ] Searched [existing issues](https://github.com/ra1028/DifferenceKit/issues) for ensure not duplicated.
9+
10+
## Expected Behavior
11+
<!--- Tell us what should happen -->
12+
13+
## Current Behavior
14+
<!--- Tell us what happens instead of the expected behavior -->
15+
16+
## Detailed Description (Include Screenshots)
17+
<!--- Provide a detailed description of your question -->
18+
19+
## Environment
20+
- Library version:
21+
22+
- Swift version:
23+
24+
- iOS version:
25+
26+
- Xcode version:
27+
28+
- Devices/Simulators:
29+
30+
- CocoaPods/Carthage version:

.github/PULL_REQUEST_TEMPLATE.md

Lines changed: 23 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,23 @@
1+
## Checklist
2+
- [ ] All tests are passed.
3+
- [ ] Added tests.
4+
- [ ] Documented the code using [Xcode markup](https://developer.apple.com/library/mac/documentation/Xcode/Reference/xcode_markup_formatting_ref).
5+
- [ ] Searched [existing pull requests](https://github.com/ra1028/DifferenceKit/pulls) for ensure not duplicated.
6+
7+
## Description
8+
<!--- Describe your changes in detail -->
9+
10+
## Related Issue
11+
<!--- This project only accepts pull requests related to open issues -->
12+
<!--- If suggesting a new feature or change, please discuss it in an issue first -->
13+
<!--- If fixing a bug, there should be an issue describing it with steps to reproduce -->
14+
<!--- Please link to the issue here: -->
15+
16+
## Motivation and Context
17+
<!--- Why is this change required? What problem does it solve? -->
18+
<!--- If it fixes an open issue, please link to the issue here. -->
19+
20+
## Impact on Existing Code
21+
<!--- Tell us the impact on existing code as far as you understand. -->
22+
23+
## Screenshots (if appropriate)

CODE_OF_CONDUCT.md

Lines changed: 76 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,76 @@
1+
# Contributor Covenant Code of Conduct
2+
3+
## Our Pledge
4+
5+
In the interest of fostering an open and welcoming environment, we as
6+
contributors and maintainers pledge to making participation in our project and
7+
our community a harassment-free experience for everyone, regardless of age, body
8+
size, disability, ethnicity, sex characteristics, gender identity and expression,
9+
level of experience, education, socio-economic status, nationality, personal
10+
appearance, race, religion, or sexual identity and orientation.
11+
12+
## Our Standards
13+
14+
Examples of behavior that contributes to creating a positive environment
15+
include:
16+
17+
* Using welcoming and inclusive language
18+
* Being respectful of differing viewpoints and experiences
19+
* Gracefully accepting constructive criticism
20+
* Focusing on what is best for the community
21+
* Showing empathy towards other community members
22+
23+
Examples of unacceptable behavior by participants include:
24+
25+
* The use of sexualized language or imagery and unwelcome sexual attention or
26+
advances
27+
* Trolling, insulting/derogatory comments, and personal or political attacks
28+
* Public or private harassment
29+
* Publishing others' private information, such as a physical or electronic
30+
address, without explicit permission
31+
* Other conduct which could reasonably be considered inappropriate in a
32+
professional setting
33+
34+
## Our Responsibilities
35+
36+
Project maintainers are responsible for clarifying the standards of acceptable
37+
behavior and are expected to take appropriate and fair corrective action in
38+
response to any instances of unacceptable behavior.
39+
40+
Project maintainers have the right and responsibility to remove, edit, or
41+
reject comments, commits, code, wiki edits, issues, and other contributions
42+
that are not aligned to this Code of Conduct, or to ban temporarily or
43+
permanently any contributor for other behaviors that they deem inappropriate,
44+
threatening, offensive, or harmful.
45+
46+
## Scope
47+
48+
This Code of Conduct applies both within project spaces and in public spaces
49+
when an individual is representing the project or its community. Examples of
50+
representing a project or community include using an official project e-mail
51+
address, posting via an official social media account, or acting as an appointed
52+
representative at an online or offline event. Representation of a project may be
53+
further defined and clarified by project maintainers.
54+
55+
## Enforcement
56+
57+
Instances of abusive, harassing, or otherwise unacceptable behavior may be
58+
reported by contacting the project team at [INSERT EMAIL ADDRESS]. All
59+
complaints will be reviewed and investigated and will result in a response that
60+
is deemed necessary and appropriate to the circumstances. The project team is
61+
obligated to maintain confidentiality with regard to the reporter of an incident.
62+
Further details of specific enforcement policies may be posted separately.
63+
64+
Project maintainers who do not follow or enforce the Code of Conduct in good
65+
faith may face temporary or permanent repercussions as determined by other
66+
members of the project's leadership.
67+
68+
## Attribution
69+
70+
This Code of Conduct is adapted from the [Contributor Covenant][homepage], version 1.4,
71+
available at https://www.contributor-covenant.org/version/1/4/code-of-conduct.html
72+
73+
[homepage]: https://www.contributor-covenant.org
74+
75+
For answers to common questions about this code of conduct, see
76+
https://www.contributor-covenant.org/faq

CONTRIBUTING.md

Lines changed: 96 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,96 @@
1+
# 💻 Contributing to DifferenceKit
2+
3+
First of all, thanks for your interest in DifferenceKit.
4+
5+
There are several ways to contribute to this project. We welcome contributions in all ways.
6+
We have made some contribution guidelines to smoothly incorporate your opinions and code into this project.
7+
8+
## 📝 Open Issue
9+
10+
When you found a bug or having a feature request, search for the issue from the [existing](https://github.com/ra1028/DifferenceKit/issues) and feel free to open the issue after making sure it isn't already reported.
11+
12+
In order to we understand your issue accurately, please include as much information as possible in the issue template.
13+
The screenshot are also big clue to understand the issue.
14+
15+
If you know exactly how to fix the bug you report or implement the feature you propose, please pull request instead of an issue.
16+
17+
## 🚀 Pull Request
18+
19+
We are waiting for a pull request to make this project more better with us.
20+
If you want to add a new feature, let's discuss about it first on issue.
21+
22+
```bash
23+
$ git clone https://github.com/ra1028/DifferenceKit.git
24+
$ cd DifferenceKit/
25+
$ open DifferenceKit.xcworkspace
26+
```
27+
28+
### Lint
29+
30+
Please introduce [SwiftLint](https://github.com/realm/SwiftLint) into your environment before start writing the code.
31+
Xcode automatically runs lint in the build phase.
32+
33+
The code written according to lint should match our coding style, but for particular cases where style is unknown, refer to the existing code base.
34+
35+
### Test
36+
37+
The test will tells us the validity of your code.
38+
All codes entering the master must pass the all tests.
39+
If you change the code or add new features, you should add tests.
40+
41+
### Documentation
42+
43+
Please write the document using [Xcode markup](https://developer.apple.com/library/archive/documentation/Xcode/Reference/xcode_markup_formatting_ref/) to the code you added.
44+
Documentation template is inserted automatically by using Xcode shortcut **⌥⌘/**.
45+
Our document style is slightly different from the template. The example is below.
46+
```swift
47+
/// The example class for documentation.
48+
final class Foo {
49+
/// A property value.
50+
let prop: Int
51+
52+
/// Create a new foo with a param.
53+
///
54+
/// - Parameters:
55+
/// - param: An Int value for prop.
56+
init(param: Int) {
57+
prop = param
58+
}
59+
60+
/// Returns a string value concatenating `param1` and `param2`.
61+
///
62+
/// - Parameters:
63+
/// - param1: An Int value for prefix.
64+
/// - param2: A String value for suffix.
65+
///
66+
/// - Returns: A string concatenating given params.
67+
func bar(param1: Int, param2: String) -> String {
68+
return "\(param1)" + param2
69+
}
70+
}
71+
```
72+
73+
## [Developer's Certificate of Origin 1.1](https://elinux.org/Developer_Certificate_Of_Origin)
74+
By making a contribution to this project, I certify that:
75+
76+
(a) The contribution was created in whole or in part by me and I
77+
have the right to submit it under the open source license
78+
indicated in the file; or
79+
80+
(b) The contribution is based upon previous work that, to the best
81+
of my knowledge, is covered under an appropriate open source
82+
license and I have the right under that license to submit that
83+
work with modifications, whether created in whole or in part
84+
by me, under the same open source license (unless I am
85+
permitted to submit under a different license), as indicated
86+
in the file; or
87+
88+
(c) The contribution was provided directly to me by some other
89+
person who certified (a), (b) or (c) and I have not modified
90+
it.
91+
92+
(d) I understand and agree that this project and the contribution
93+
are public and that a record of the contribution (including all
94+
personal information I submit with it, including my sign-off) is
95+
maintained indefinitely and may be redistributed consistent with
96+
this project or the open source license(s) involved.

DifferenceKit.xcodeproj/project.pbxproj

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,7 @@
9292
children = (
9393
6B5B4085211066B300A931DB /* Sources */,
9494
6B5B4092211066BF00A931DB /* Tests */,
95-
6B2DF889210E39A8004D2D40 /* Configurations */,
95+
6B2DF889210E39A8004D2D40 /* XCConfigs */,
9696
6B2DF86F210E2C12004D2D40 /* Products */,
9797
);
9898
sourceTree = "<group>";
@@ -106,12 +106,12 @@
106106
name = Products;
107107
sourceTree = "<group>";
108108
};
109-
6B2DF889210E39A8004D2D40 /* Configurations */ = {
109+
6B2DF889210E39A8004D2D40 /* XCConfigs */ = {
110110
isa = PBXGroup;
111111
children = (
112112
6B2DF88A210E39A8004D2D40 /* DifferenceKit.xcconfig */,
113113
);
114-
path = Configurations;
114+
path = XCConfigs;
115115
sourceTree = "<group>";
116116
};
117117
6B5B4085211066B300A931DB /* Sources */ = {

Gemfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
11
source "https://rubygems.org"
22

33
gem 'cocoapods', '1.6.1'
4-
gem 'jazzy', '0.9.3'
4+
gem 'jazzy', '0.9.4'

Gemfile.lock

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ GEM
5151
gh_inspector (1.1.3)
5252
i18n (0.9.5)
5353
concurrent-ruby (~> 1.0)
54-
jazzy (0.9.3)
54+
jazzy (0.9.4)
5555
cocoapods (~> 1.0)
5656
mustache (~> 0.99)
5757
open4
@@ -97,7 +97,7 @@ PLATFORMS
9797

9898
DEPENDENCIES
9999
cocoapods (= 1.6.1)
100-
jazzy (= 0.9.3)
100+
jazzy (= 0.9.4)
101101

102102
BUNDLED WITH
103103
1.17.1

Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ lib-lint:
88
bundle exec pod lib lint
99

1010
pod-release:
11-
bundle exec pod trunk push
11+
bundle exec pod trunk push --allow-warnings
1212

1313
test-linux:
1414
sh scripts/test-linux.sh

0 commit comments

Comments
 (0)