fix: keep hydrated keyword searches on public search

Author: ra1nty

polymarket_cli/api.py

@@ -229,7 +229,7 @@ def search_markets(
             return []
 
         gamma_order = self._normalize_market_order(order)
-        requires_ranked_search = any(
+        requires_market_search = any(
             value
             for value in (
                 offset,
@@ -249,10 +249,9 @@ def search_markets(
                 active is not True,
                 closed is not False,
                 gamma_order != "volume_24hr",
-                hydrate,
             )
         )
-        if requires_ranked_search:
+        if requires_market_search:
             try:
                 return self.list_markets(
                     limit=limit,
@@ -279,12 +278,16 @@ def search_markets(
             except ApiError:
                 pass
 
-        candidate_limit = self._search_candidate_limit(limit=limit, offset=offset, hydrate=hydrate or requires_ranked_search)
+        candidate_limit = self._search_candidate_limit(
+            limit=limit,
+            offset=offset,
+            hydrate=hydrate or requires_market_search,
+        )
         markets = self._search_public_markets(query, limit=candidate_limit)
         if not markets:
             return []
 
-        if hydrate or requires_ranked_search:
+        if hydrate or self._public_search_needs_hydration(markets, order=gamma_order):
             markets = self._hydrate_markets(markets, order=gamma_order, include_tokens=True)
 
         filtered = self._filter_markets(
@@ -379,6 +382,9 @@ def _search_candidate_limit(self, *, limit: int, offset: int, hydrate: bool) ->
             return max(minimum, 1)
         return max(minimum * 5, 25)
 
+    def _public_search_needs_hydration(self, markets: list[dict[str, Any]], *, order: str) -> bool:
+        return any(self._market_needs_hydration(dict(market), order=order, include_tokens=False) for market in markets)
+
     def _hydrate_markets(self, markets: list[dict[str, Any]], *, order: str, include_tokens: bool) -> list[dict[str, Any]]:
         hydrated = []
         for market in markets:

tests/test_api.py

@@ -222,6 +222,48 @@ def test_search_markets_uses_markets_endpoint_when_advanced_filters_requested(se
         self.assertEqual(len(markets), 1)
         self.assertEqual(markets[0]["id"], "1669969")
 
+    def test_search_markets_keeps_plain_hydrated_query_on_public_search(self):
+        detail = load_fixture("market_detail.json")
+        public_search = {
+            "events": [
+                {
+                    "markets": [
+                        {
+                            "slug": detail["slug"],
+                            "question": detail["question"],
+                            "id": None,
+                            "conditionId": None,
+                            "volume24hr": None,
+                        }
+                    ]
+                }
+            ]
+        }
+        http = StubHttpClient(
+            [
+                (
+                    "https://gamma-api.polymarket.com/public-search",
+                    {
+                        "q": "bitcoin",
+                        "limit_per_type": 50,
+                        "search_tags": False,
+                        "search_profiles": False,
+                        "optimized": True,
+                    },
+                    public_search,
+                ),
+                (f"https://gamma-api.polymarket.com/markets/slug/{detail['slug']}", None, detail),
+            ]
+        )
+
+        client = PolymarketClient(http=http)
+
+        markets = client.search_markets("bitcoin", hydrate=True)
+
+        self.assertEqual(len(markets), 1)
+        self.assertEqual(markets[0]["slug"], detail["slug"])
+        self.assertTrue(markets[0]["clobTokenIds"])
+
     def test_search_markets_falls_back_to_public_search_and_hydrates_ranked_results(self):
         detail_a = load_fixture("market_detail.json")
         detail_b = dict(detail_a)