Update v2.6.2

Author: rabanti-github

Changelog.md

@@ -1,5 +1,14 @@
 # Change Log
 
+## v2.6.2 
+
+---
+Release Date: **24.01.2025**
+
+- Fixed a regression bug in the Cell function ConvertArray
+- Added test cases
+
+
 ## v2.6.1 
 
 ---

Demo/Demo.csproj

@@ -15,9 +15,9 @@
     <SymbolPackageFormat>snupkg</SymbolPackageFormat>
     <TargetFrameworks>net45;net5.0</TargetFrameworks>
     <StartupObject>Demo.Program</StartupObject>
-    <Version>2.6.1</Version>
-    <AssemblyVersion>2.6.1.0</AssemblyVersion>
-    <FileVersion>2.6.1.0</FileVersion>
+    <Version>2.6.2</Version>
+    <AssemblyVersion>2.6.2.0</AssemblyVersion>
+    <FileVersion>2.6.2.0</FileVersion>
     <GeneratePackageOnBuild>false</GeneratePackageOnBuild>
     <PackageLicenseExpression>MIT</PackageLicenseExpression>
     <PackageTags>XLSX Excel ExcelWriter ExcelReader Office</PackageTags>

NanoXLSX/Cell.cs

@@ -450,7 +450,7 @@ public static IEnumerable<Cell> ConvertArray<T>(IEnumerable<T> list)
             Type t;
             foreach (T item in list)
             {
-                if (object.Equals(item, default(T)))
+                if (item == null) // DO NOT LISTEN to code suggestions! This is wrong for bool: if (object.Equals(item, default(T)))
                 {
                     c = new Cell(null, CellType.EMPTY);
                     output.Add(c);

NanoXLSX/NanoXLSX.csproj

@@ -23,9 +23,9 @@
     <PackageLicenseFile></PackageLicenseFile>
     <PackageReleaseNotes>Please see https://github.com/rabanti-github/NanoXLSX/blob/master/Changelog.md for the release notes</PackageReleaseNotes>
     <PackageLicenseExpression>MIT</PackageLicenseExpression>
-    <Version>2.6.1</Version>
-    <AssemblyVersion>2.6.1.0</AssemblyVersion>
-    <FileVersion>2.6.1.0</FileVersion>
+    <Version>2.6.2</Version>
+    <AssemblyVersion>2.6.2.0</AssemblyVersion>
+    <FileVersion>2.6.2.0</FileVersion>
     <RepositoryType>git</RepositoryType>
     <GenerateDocumentationFile>True</GenerateDocumentationFile>
   </PropertyGroup>

NanoXLSX/Worksheet.cs

@@ -1438,7 +1438,7 @@ public void InsertRow(int rowNumber, int numberOfNewRows)
             var upperRow = this.GetRow(rowNumber);
 
             // Identify all cells below the insertion point to adjust their addresses
-            var cellsToChange = this.Cells.Where(c => c.Value.CellAddress2.Row > rowNumber).ToList();
+            List<KeyValuePair<string, Cell>> cellsToChange = this.Cells.Where(c => c.Value.CellAddress2.Row > rowNumber).ToList();
 
             // Make a copy of the cells to be moved and then delete the original cells;
             Dictionary<string, Cell> newCells = new Dictionary<string, Cell>();

NanoXlsx Test/NanoXLSX Test.csproj

@@ -17,9 +17,9 @@
     <PackageTags>Excel Office XLSX</PackageTags>
     <RepositoryType>git</RepositoryType>
     <PackageReleaseNotes>Please see https://github.com/rabanti-github/NanoXLSX/blob/master/Changelog.md for the release notes</PackageReleaseNotes>
-    <Version>2.6.1</Version>
-    <AssemblyVersion>2.6.1.0</AssemblyVersion>
-    <FileVersion>2.6.1.0</FileVersion>
+    <Version>2.6.2</Version>
+    <AssemblyVersion>2.6.2.0</AssemblyVersion>
+    <FileVersion>2.6.2.0</FileVersion>
   </PropertyGroup>
   <ItemGroup>
     <None Remove="Resources\autofilter.xlsx" />

NanoXlsx Test/Worksheets/WorksheetTest.cs

@@ -1569,6 +1569,26 @@ public void ReplaceCellValue_ShouldReplaceAllOccurrences(object? oldValue, objec
             Assert.Equal(differentValue, worksheet.Cells["D1"].Value);
         }
 
+        [Fact(DisplayName = "Test of the ReplaceCellValue on an existing occurrence of a DateTime value")]
+        public void ReplaceCellValue_ShouldReplaceAllOccurrences2()
+        {
+            var worksheet = new Worksheet();
+            string oldValue = "oldValue";
+            worksheet.AddCell(oldValue, 0, 0);
+            worksheet.AddCell(oldValue, 1, 0);
+            worksheet.AddCell(oldValue, 2, 0);
+            worksheet.AddCell("differentValue", 3, 0);
+
+            DateTime newValue = new DateTime(2025, 02, 10, 5, 6, 7, DateTimeKind.Utc);
+            int replacedCount = worksheet.ReplaceCellValue(oldValue, newValue);
+
+            Assert.Equal(3, replacedCount);
+            Assert.Equal(newValue, worksheet.Cells["A1"].Value);
+            Assert.Equal(newValue, worksheet.Cells["B1"].Value);
+            Assert.Equal(newValue, worksheet.Cells["C1"].Value);
+            Assert.Equal("differentValue", worksheet.Cells["D1"].Value);
+        }
+
         [Theory(DisplayName = "Test of the ReplaceCellValue when one existing values is to replace")]
         [InlineData("oldValue", "newValue", "differentValue")]
         [InlineData("oldValue", 23, true)]
@@ -1663,7 +1683,24 @@ public void FirstCellByValue_ShouldReturnCorrectCell(object? matchingValue)
         {
             var worksheet = new Worksheet();
             var cell1 = new Cell("Test1", CellType.STRING, "A1");
-            var cell2 = new Cell(matchingValue, CellType.STRING, "B1");
+            var cell2 = new Cell(matchingValue, CellType.DEFAULT, "B1");
+            worksheet.Cells.Add("A1", cell1);
+            worksheet.Cells.Add("B1", cell2);
+
+            Cell? result = worksheet.FirstCellByValue(matchingValue);
+
+            Assert.NotNull(result);
+            Assert.Equal(matchingValue, ((Cell)result).Value);
+            Assert.Equal("B1", result.CellAddress);
+        }
+
+        [Fact(DisplayName = "Test of the FirstCellByValue when one existing values exists, on a DateTime value")]
+        public void FirstCellByValue_ShouldReturnCorrectCell2()
+        {
+            var worksheet = new Worksheet();
+            var cell1 = new Cell("Test1", CellType.STRING, "A1");
+            DateTime matchingValue = new DateTime(2025, 02, 10, 5, 6, 7, DateTimeKind.Utc);
+            var cell2 = new Cell(matchingValue, CellType.DATE, "B1");
             worksheet.Cells.Add("A1", cell1);
             worksheet.Cells.Add("B1", cell2);
 
@@ -1693,11 +1730,8 @@ public void FirstCellByValue_ShouldReturnNull_WhenValueNotFound(object? notMatch
 
             Assert.Null(result);
         }
-
-
 #nullable disable
 
-
         [Fact(DisplayName = "Test of the InsertRow function")]
         public void TestInsertRow()
         {
@@ -1769,12 +1803,8 @@ public void TestInsertColumn()
             Assert.Null(worksheet.Cells["F2"].CellStyle);
             Assert.Null(worksheet.Cells["H3"].CellStyle);
         }
-
-
         #endregion
 
-
-
         public static Worksheet InitWorksheet(Worksheet worksheet, string address, Worksheet.CellDirection direction, Style style = null)
         {
             if (worksheet == null)