Skip to content

Cover more built-in exchange types (backport #1918) #1922

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
michaelklishin merged 1 commit into from
Mar 31, 2026
+12 −3
Merged

Cover more built-in exchange types (backport #1918) #1922

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/main/java/com/rabbitmq/client/BuiltinExchangeType.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,9 @@
*/
public enum BuiltinExchangeType {

DIRECT("direct"), FANOUT("fanout"), TOPIC("topic"), HEADERS("headers");
DIRECT("direct"), FANOUT("fanout"), TOPIC("topic"), HEADERS("headers"),
CONSISTENT_HASH("x-consistent-hash"), MODULUS_HASH("x-modulus-hash"),
LOCAL_RANDOM("x-local-random"), RANDOM("x-random");

private final String type;

Expand Down
11 changes: 9 additions & 2 deletions src/test/java/com/rabbitmq/client/test/functional/ExchangeDeclare.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,9 @@
import static org.junit.jupiter.api.Assertions.assertEquals;

import java.io.IOException;
import java.util.Arrays;
import java.util.HashMap;
import java.util.List;
import java.util.Map;
import java.util.concurrent.TimeoutException;

Expand Down Expand Up @@ -101,8 +103,13 @@ public void releaseResources() throws IOException {
}

private void doTestExchangeDeclaredWithEnumerationEquivalent(Channel channel) throws IOException, InterruptedException {
assertEquals(4, BuiltinExchangeType.values().length, "There are 4 standard exchange types");
for (BuiltinExchangeType exchangeType : BuiltinExchangeType.values()) {
// Only test AMQP 0-9-1 standard types; plugin and newer core types
// (e.g. x-modulus-hash, x-local-random) may not be available on the test broker
List<BuiltinExchangeType> standardTypes = Arrays.asList(
BuiltinExchangeType.DIRECT, BuiltinExchangeType.FANOUT,
BuiltinExchangeType.TOPIC, BuiltinExchangeType.HEADERS
);
for (BuiltinExchangeType exchangeType : standardTypes) {
channel.exchangeDeclare(NAME, exchangeType);
verifyEquivalent(NAME, exchangeType.getType(), false, false, null);
channel.exchangeDelete(NAME);
Expand Down