Skip to content

Commit c75d4e0

Browse files
committed
remove uploading kcap, submit live capture
1 parent 24ba345 commit c75d4e0

4 files changed

Lines changed: 2 additions & 11 deletions

File tree

.github/workflows/master.yml

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -169,14 +169,6 @@ jobs:
169169
./make.bat test
170170
env:
171171
TAGS: kcap,filament,yara,yara_static
172-
- uses: actions/upload-artifact@v2
173-
with:
174-
name: "test.kcap"
175-
path: "./test.kcap"
176-
- name: List cwd
177-
shell: bash
178-
run: |
179-
ls -ltr
180172

181173
lint:
182174
runs-on: windows-latest

pkg/kcap/_fixtures/test.kcap

1.91 MB
Binary file not shown.

pkg/kcap/writer_windows.go

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -251,9 +251,7 @@ func (w *writer) Close() error {
251251
if err := w.zw.Close(); err != nil {
252252
return err
253253
}
254-
}
255-
if w.zw != nil {
256-
//w.zw.Release()
254+
w.zw.Release()
257255
}
258256
if w.f != nil {
259257
return w.f.Close()

pkg/kcap/writer_windows_test.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -165,6 +165,7 @@ func TestWrite(t *testing.T) {
165165
}
166166

167167
func TestLiveKcap(t *testing.T) {
168+
t.SkipNow()
168169
cfg := &config.Config{
169170
Kstream: config.KstreamConfig{
170171
EnableFileIOKevents: true,

0 commit comments

Comments
 (0)