refactor(stackwalk): Associate stack walk events by timestamp#677
Open
rabbitstack wants to merge 3 commits into
Open
refactor(stackwalk): Associate stack walk events by timestamp#677rabbitstack wants to merge 3 commits into
rabbitstack wants to merge 3 commits into
Conversation
The CreateFile event callstack is attached early in the approver stage, reducing the amount of StackWalk events we propagate to downstream components. The callstack is appended to CreateFile event parameters.
Historically, we relied on a bucketed queue per stack id to link the stackwalk to its respective event. This approach can introduce wrong attributions if the stackwalk event is not emitted or dropped. The optimal strategy is to index the event per its raw timestamp, await for the stackwalk where the timestamp parameter is equal to the original event timestamp, and enrich the event with return addresses.
This change is necessary to correctly attribute stack walk event timestamps.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of this PR / why it is needed?
Historically, we relied on a bucketed queue per stack ID to link the stackwalk to its respective event. This approach can lead to incorrect attributions if the stackwalk event is not emitted or dropped.
The optimal strategy is to index the event per its raw timestamp, await the stackwalk where the timestamp parameter is equal to the original event timestamp, and enrich the event with return addresses.
What type of change does this PR introduce?
/kind refactor (non-breaking change that restructures the code, while not changing the original functionality)
/kind improvement
Any specific area of the project related to this PR?
/area instrumentation
/area event
Special notes for the reviewer
Does this PR introduce a user-facing change?