Skip to content

Commit 30cc4a7

Browse files
author
Jegors Cemisovs
committed
Address code review comments and make SonarQube conditional on SONAR_TOKEN
1 parent 2457561 commit 30cc4a7

2 files changed

Lines changed: 9 additions & 4 deletions

File tree

.github/workflows/build.yml

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,4 +34,9 @@ jobs:
3434
env:
3535
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} # Needed to get PR information, if any
3636
SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }}
37-
run: ./gradlew build sonarqube --info
37+
run: |
38+
if [ -n "$SONAR_TOKEN" ]; then
39+
./gradlew build sonarqube --info
40+
else
41+
./gradlew build --info
42+
fi

graph-shell/README.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,19 +14,19 @@ You can build and run this program easily using **mise**:
1414
$ mise run demo-shell
1515
```
1616

17-
Alternatively, you can compile and run using Gradle manually (using the tool chain managed by `mise` or system tools):
17+
Alternatively, you can compile and run using Gradle manually (using the toolchain managed by `mise` or system tools):
1818

1919
To compile:
2020
```shell
2121
$ gradle assemble
2222
```
2323

24-
This command will create an executable jar. On Linux or macOS you can run it via:
24+
This command will create an executable JAR. On Linux or macOS you can run it via:
2525
```shell
2626
$ ./build/libs/graph-shell-1.0-SNAPSHOT.jar
2727
```
2828

29-
On a Windows machine you should run the application using java:
29+
On a Windows machine you should run the application using Java:
3030
```shell
3131
$ java -jar ./build/libs/graph-shell-1.0-SNAPSHOT.jar
3232
```

0 commit comments

Comments
 (0)