fix(chunk): handle binary data and non-string chunks safely. Fixes #162

Author: rachartier

lua/tiny-inline-diagnostic/chunk.lua

@@ -11,9 +11,11 @@ function M.get_max_width_from_chunks(chunks)
   local max_chunk_line_length = 0
 
   for _, chunk in ipairs(chunks) do
-    local line_length = vim.fn.strdisplaywidth(chunk)
-    if line_length > max_chunk_line_length then
-      max_chunk_line_length = line_length
+    if type(chunk) == "string" then
+      local ok, line_length = pcall(vim.fn.strdisplaywidth, chunk)
+      if ok and line_length > max_chunk_line_length then
+        max_chunk_line_length = line_length
+      end
     end
   end
 

tests/test_chunk.lua

@@ -23,6 +23,24 @@ T["get_max_width_from_chunks"]["handles single chunk"] = function()
   MiniTest.expect.equality(result, 6)
 end
 
+T["get_max_width_from_chunks"]["handles binary data with null bytes"] = function()
+  local chunks = { "\x00\xff", "valid text" }
+  local result = chunk.get_max_width_from_chunks(chunks)
+  MiniTest.expect.equality(result, vim.fn.strdisplaywidth("valid text"))
+end
+
+T["get_max_width_from_chunks"]["ignores non-string chunks"] = function()
+  local chunks = { "text", 123, "longer text", { "table" }, nil }
+  local result = chunk.get_max_width_from_chunks(chunks)
+  MiniTest.expect.equality(result, vim.fn.strdisplaywidth("longer text"))
+end
+
+T["get_max_width_from_chunks"]["returns zero for all non-string chunks"] = function()
+  local chunks = { 123, { "table" }, true, nil }
+  local result = chunk.get_max_width_from_chunks(chunks)
+  MiniTest.expect.equality(result, 0)
+end
+
 T["get_diagnostic_icon"] = MiniTest.new_set()
 
 T["get_diagnostic_icon"]["returns default icon when use_icons_from_diagnostic is false"] = function()