fix: ensure the new logic is used for the cursorline visibility check#166
Merged
rachartier merged 1 commit intorachartier:mainfrom Jan 4, 2026
Merged
fix: ensure the new logic is used for the cursorline visibility check#166rachartier merged 1 commit intorachartier:mainfrom
rachartier merged 1 commit intorachartier:mainfrom
Conversation
in a previous commit, the logic was changed from simply checking the cursorline option to also considering the related cursorlineopt option to verify that the full cursorline is drawn. there is unfortunately one more spot in the code i've missed
Owner
|
That's my bad, I should have checked better! Thanks |
Contributor
Author
|
no, that's almost completely on me, since i've opted to make a pr without properly checking if my changes actually did the thing they were supposed to do again, sorry and thank you for your patience |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this is very embarrassing, but in a previous commit, the logic was changed from simply checking the cursorline option to also considering the related cursorlineopt option to verify that the full cursorline is drawn and thus visible.
there is unfortunately one more spot in the code i've missed that needs to use the new logic too
i'm terribly sorry to notice it this late, especially considering that the original pr was just merged