Skip to content

Commit d7a7a8b

Browse files
authored
readme: Clarify AS::Notification.subscribe arguments (#654)
* fix AS::Notification.subscribe arguments in README.md * event_id -> instrumenter_id
1 parent 429fb7f commit d7a7a8b

1 file changed

Lines changed: 3 additions & 3 deletions

File tree

README.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -291,7 +291,7 @@ Rack::Attack.track("special_agent", limit: 6, period: 60) do |req|
291291
end
292292

293293
# Track it using ActiveSupport::Notification
294-
ActiveSupport::Notifications.subscribe("track.rack_attack") do |name, start, finish, request_id, payload|
294+
ActiveSupport::Notifications.subscribe("track.rack_attack") do |name, start, finish, instrumenter_id, payload|
295295
req = payload[:request]
296296
if req.env['rack.attack.matched'] == "special_agent"
297297
Rails.logger.info "special_agent: #{req.path}"
@@ -383,7 +383,7 @@ To get notified about specific type of events, subscribe to the event name follo
383383
E.g. for throttles use:
384384

385385
```ruby
386-
ActiveSupport::Notifications.subscribe("throttle.rack_attack") do |name, start, finish, request_id, payload|
386+
ActiveSupport::Notifications.subscribe("throttle.rack_attack") do |name, start, finish, instrumenter_id, payload|
387387
# request object available in payload[:request]
388388

389389
# Your code here
@@ -393,7 +393,7 @@ end
393393
If you want to subscribe to every `rack_attack` event, use:
394394

395395
```ruby
396-
ActiveSupport::Notifications.subscribe(/rack_attack/) do |name, start, finish, request_id, payload|
396+
ActiveSupport::Notifications.subscribe(/rack_attack/) do |name, start, finish, instrumenter_id, payload|
397397
# request object available in payload[:request]
398398

399399
# Your code here

0 commit comments

Comments
 (0)