fix(kea driver): fix reservation removal using list.pop instead of remove

list.pop() expects an index, not a value; passing the reservation dict
raised TypeError, silently swallowed by the broad except clause, so
clean_dhcp_opts never actually removed reservations.

Author: skrobul

python/ironic-understack/ironic_understack/dhcp/kea.py

@@ -120,7 +120,7 @@ def _update_host_reservation(self, hw_address, boot_file_prefix=None, remove=Fal
                         reservation["client-classes"] = ["BOOTSRV_A"]
                     else:
                         print(f"REMOVING RESERVATION: {reservation}")
-                        reservations.pop(reservation)
+                        reservations.remove(reservation)
                     found = True
                     break
             if not found:

python/ironic-understack/ironic_understack/tests/test_dhcp_kea.py

@@ -68,3 +68,28 @@ def test_make_request_succeeds_on_first_attempt(kea, mocker):
 
     assert result == {"result": 0}
     assert post.call_count == 1
+
+
+def test_update_host_reservation_removes_existing_entry(kea, mocker):
+    other_reservation = {
+        "hw-address": "aa:aa:aa:aa:aa:aa",
+        "client-classes": ["BOOTSRV_A"],
+    }
+    target_reservation = {
+        "hw-address": "bb:bb:bb:bb:bb:bb",
+        "client-classes": ["BOOTSRV_A"],
+    }
+    config = {
+        "arguments": {
+            "hash": "somehash",
+            "Dhcp4": {"reservations": [other_reservation, target_reservation]},
+        }
+    }
+    mocker.patch.object(kea, "get_config", return_value=config)
+    set_config = mocker.patch.object(kea, "set_config")
+
+    result = kea._update_host_reservation("bb:bb:bb:bb:bb:bb", remove=True)
+
+    assert result is True
+    sent_config = set_config.call_args[0][0]
+    assert sent_config["Dhcp4"]["reservations"] == [other_reservation]