Perform a second agent inspection boot to commit BIOS settings change

We're seeing obscure errors from Ironic like:

failed step {'interface': 'raid', 'step': 'delete_configuration',
'abortable': False, 'priority': 0}: Unable to connect to
/redfish/v1/TaskService/Tasks/JID_768614980495. Error: Timeout waiting
for task monitor /redfish/v1/TaskService/Tasks/JID_768614980495 (timeout
= 500)

To clear this up, we are completing each operation with a separate
reboot.

Author: stevekeay

python/understack-workflows/tests/test_enroll_server.py

@@ -202,8 +202,12 @@ def test_enrol_happy_path_uses_virtual_media_inspect_and_flips_back(mocker):
     ]
     fake_ironic, created_node = make_ironic_client(
         node_name="Dell-ABC123",
-        # OOB inspect, agent inspect, OOB inspect (post-RAID).
-        inspect_interfaces=["idrac-redfish", "idrac-redfish", "idrac-redfish"],
+        inspect_interfaces=[
+            "idrac-redfish",
+            "idrac-redfish",
+            "idrac-redfish",
+            "idrac-redfish",
+        ],
         inventory=inventory,
         ports=ports,
     )
@@ -216,7 +220,7 @@ def test_enrol_happy_path_uses_virtual_media_inspect_and_flips_back(mocker):
     )
     bmc_set_hostname = mocker.patch.object(enroll_server, "bmc_set_hostname")
     update_dell_bios_settings = mocker.patch.object(
-        enroll_server, "update_dell_bios_settings"
+        enroll_server, "update_dell_bios_settings", return_value={"changed": True}
     )
     mocker.patch(
         "understack_workflows.ironic.client.get_ironic_client",
@@ -297,6 +301,20 @@ def test_enrol_happy_path_uses_virtual_media_inspect_and_flips_back(mocker):
                 runbook=None,
                 disable_ramdisk=None,
             ),
+            call(
+                created_node.uuid,
+                "clean",
+                cleansteps=[{"interface": "management", "step": "clear_job_queue"}],
+                runbook=None,
+                disable_ramdisk=True,
+            ),
+            call(
+                created_node.uuid,
+                "inspect",  # second agent inspect to apply BIOS changes
+                cleansteps=None,
+                runbook=None,
+                disable_ramdisk=None,
+            ),
             call(
                 created_node.uuid,
                 "clean",
@@ -334,6 +352,9 @@ def test_enrol_happy_path_uses_virtual_media_inspect_and_flips_back(mocker):
         call(created_node.uuid, expected_ipxe_boot),
         call(created_node.uuid, expected_agent),
         call(created_node.uuid, expected_ipxe_boot),
+        call(created_node.uuid, expected_ipxe_boot),
+        call(created_node.uuid, expected_agent),
+        call(created_node.uuid, expected_ipxe_boot),
         call(created_node.uuid, expected_reset),  # Post-RAID OOB inspect prep
     ]
 
@@ -371,7 +392,9 @@ def test_enrol_existing_failed_node_recovers_and_updates(mocker):
     mocker.patch.object(enroll_server, "set_bmc_password")
     mocker.patch.object(enroll_server, "update_dell_drac_settings")
     mocker.patch.object(enroll_server, "bmc_set_hostname")
-    mocker.patch.object(enroll_server, "update_dell_bios_settings")
+    mocker.patch.object(
+        enroll_server, "update_dell_bios_settings", return_value={"changed": True}
+    )
     mocker.patch(
         "understack_workflows.ironic.client.get_ironic_client",
         return_value=fake_ironic,
@@ -410,6 +433,20 @@ def test_enrol_existing_failed_node_recovers_and_updates(mocker):
                 runbook=None,
                 disable_ramdisk=None,
             ),
+            call(
+                existing_node.uuid,
+                "clean",
+                cleansteps=[{"interface": "management", "step": "clear_job_queue"}],
+                runbook=None,
+                disable_ramdisk=True,
+            ),
+            call(
+                existing_node.uuid,
+                "inspect",  # second agent inspect to apply BIOS changes
+                cleansteps=None,
+                runbook=None,
+                disable_ramdisk=None,
+            ),
             call(
                 existing_node.uuid,
                 "provide",

python/understack-workflows/understack_workflows/main/enroll_server.py

@@ -121,7 +121,10 @@ def enroll(
         )
     logger.info("[node:%s] Selected PXE interface %s", node.uuid, pxe_interface)
 
-    update_dell_bios_settings(bmc, pxe_interface=pxe_interface)
+    # This sets the boot device to use for all future HTTP boots:
+    if update_dell_bios_settings(bmc, pxe_interface=pxe_interface):
+        logger.info("%s performing second inspection write BIOS settings", node.uuid)
+        agent_inspection(node)
 
     if raid_configure:
         configure_raid(node, bmc)