Skip to content

Commit 4993fae

Browse files
RSaboundsstevekeay
authored andcommitted
fix formats and Sushy usage.
1 parent 9a4ffa9 commit 4993fae

1 file changed

Lines changed: 16 additions & 14 deletions

File tree

python/understack-workflows/understack_workflows/main/get_raid_devices.py

Lines changed: 16 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -1,31 +1,31 @@
11
import argparse
22
import json
3-
import logging.config
43
import logging
4+
import logging.config
55
import os
66

7-
import sushy
7+
from sushy import Sushy
88

9-
from understack_workflows.bmc import Bmc
109
from understack_workflows.bmc import bmc_for_ip_address
1110
from understack_workflows.helpers import setup_logger
1211

1312
logger = setup_logger(__name__)
1413

1514
log_config = {
16-
'version': 1,
17-
'disable_existing_loggers': False,
18-
'loggers': {
19-
"__main__": {'level': 'INFO'},
20-
"sushy.main": {'level': 'INFO'},
21-
"sushy.resources.base": {'level': 'INFO'},
22-
"sushy.connector": {'level': 'INFO'},
23-
"urllib3.connectionpool": {'level': 'INFO'},
24-
}
15+
"version": 1,
16+
"disable_existing_loggers": False,
17+
"loggers": {
18+
"__main__": {"level": "INFO"},
19+
"sushy.main": {"level": "INFO"},
20+
"sushy.resources.base": {"level": "INFO"},
21+
"sushy.connector": {"level": "INFO"},
22+
"urllib3.connectionpool": {"level": "INFO"},
23+
},
2524
}
2625

2726
logging.config.dictConfig(log_config)
2827

28+
2929
def main():
3030
"""Export RAID details for a BMC using Sushy.
3131
@@ -57,11 +57,13 @@ def argument_parser():
5757
prog=os.path.basename(__file__), description="Gather RAID Device info."
5858
)
5959
parser.add_argument("--ip-address", type=str, required=True, help="BMC IP")
60-
parser.add_argument("--password", type=str, required=False, help="Password", default=None)
60+
parser.add_argument(
61+
"--password", type=str, required=False, help="Custom Password", default=None
62+
)
6163
return parser
6264

6365

64-
def parse_controller_details(client) -> dict:
66+
def parse_controller_details(client: Sushy) -> dict:
6567
"""Parse available RAID controller details for execution."""
6668
result = {"controller": None, "physical_disks": []}
6769
system_objects = client.get_system_collection().get_members()

0 commit comments

Comments
 (0)