1- From 3220a0cc6617dfa026ff3febc0bdd4a227320759 Mon Sep 17 00:00:00 2001
1+ From da011a985fce208c3ad4eeb13d635323b1cbfc8d Mon Sep 17 00:00:00 2001
22From: Doug Goldstein <cardoe@cardoe.com>
33Date: Tue, 13 Jan 2026 11:49:05 -0600
4- Subject: [PATCH] feat: skip invalid mac addr interfaces in redfish inspect add
5- speed
4+ Subject: [PATCH 5/8 ] feat: skip invalid mac addr interfaces in redfish inspect
5+ add speed
66
77Refactor the redfish interfaces inspection by moving it to its own
88function, but preserving the behavior of not having an interfaces key in
@@ -18,7 +18,7 @@ Signed-off-by: Doug Goldstein <cardoe@cardoe.com>
1818 2 files changed, 35 insertions(+), 8 deletions(-)
1919
2020diff --git a/ironic/drivers/modules/redfish/inspect.py b/ironic/drivers/modules/redfish/inspect.py
21- index 6f951f237..5ee052713 100644
21+ index 69f0f0c09..9786c9f46 100644
2222--- a/ironic/drivers/modules/redfish/inspect.py
2323+++ b/ironic/drivers/modules/redfish/inspect.py
2424@@ -14,6 +14,7 @@ Redfish Inspect Interface
@@ -41,9 +41,9 @@ index 6f951f237..5ee052713 100644
4141- inventory['interfaces'].append(iface)
4242+ inventory['interfaces'] = self._get_interface_info(task, system)
4343
44- pcie_devices = self._get_pcie_devices(system.pcie_devices)
45- if pcie_devices :
46- @@ -310 ,6 +306 ,33 @@ class RedfishInspect(base.InspectInterface):
44+ system_vendor = {}
45+ if system.model :
46+ @@ -297 ,6 +293 ,33 @@ class RedfishInspect(base.InspectInterface):
4747 """
4848 return None
4949
@@ -78,7 +78,7 @@ index 6f951f237..5ee052713 100644
7878 # NOTE(JayF): Checking truthiness here is better than checking for None
7979 # because if we have an empty list, we'll raise a
8080diff --git a/ironic/tests/unit/drivers/modules/redfish/test_inspect.py b/ironic/tests/unit/drivers/modules/redfish/test_inspect.py
81- index fd9c9e398..b3ba67c9f 100644
81+ index c81fb3934..4b8d08217 100644
8282--- a/ironic/tests/unit/drivers/modules/redfish/test_inspect.py
8383+++ b/ironic/tests/unit/drivers/modules/redfish/test_inspect.py
8484@@ -108,6 +108,7 @@ class RedfishInspectTestCase(db_base.DbTestCase):
@@ -97,7 +97,7 @@ index fd9c9e398..b3ba67c9f 100644
9797 eth_interface_mock2.status.state = sushy.STATE_DISABLED
9898 eth_interface_mock2.status.health = sushy.HEALTH_OK
9999
100- @@ -235 ,9 +237 ,11 @@ class RedfishInspectTestCase(db_base.DbTestCase):
100+ @@ -203 ,9 +205 ,11 @@ class RedfishInspectTestCase(db_base.DbTestCase):
101101 system_vendor['system_uuid'])
102102
103103 expected_interfaces = [{'mac_address': '00:11:22:33:44:55',
0 commit comments