chore: set defaults for argocd-understack to be false

Rather than defaulting to everything enabled by default and surprising
people and having a service enabled without proper configs, default
everything to false and require users to enable each thing as they go.

Author: cardoe

.github/workflows/helm-chart-test.yaml

@@ -53,6 +53,28 @@ jobs:
             done
           fi
 
+      - name: Validate argocd-understack default enabled flags
+        if: steps.list-changed.outputs.argocd-understack == 'true'
+        run: |
+          file=charts/argocd-understack/values.yaml
+          violations=$(awk '
+            /^[^[:space:]#][^:]*:[[:space:]]*$/ {
+              in_scope = ($0 ~ /^(global|site):[[:space:]]*$/)
+            }
+            in_scope && /^[[:space:]]+# @default -- true([[:space:]]*#.*)?$/ {
+              print NR ":" $0
+            }
+            in_scope && /^[[:space:]]+enabled:[[:space:]]*true([[:space:]]*#.*)?$/ {
+              print NR ":" $0
+            }
+          ' "$file")
+
+          if [[ -n "$violations" ]]; then
+            echo "argocd-understack defaults under global/site must be false in $file"
+            echo "$violations"
+            exit 1
+          fi
+
       - name: Run chart-testing (lint)
         if: steps.list-changed.outputs.changed == 'true'
         run: ct lint --chart-dirs charts --target-branch ${{ github.event.repository.default_branch }} --check-version-increment=false

charts/argocd-understack/README.md

@@ -109,8 +109,8 @@ helm install argocd-understack oci://ghcr.io/rackerlabs/understack/argocd-unders
 | `understack_url` | UnderStack repository URL | `https://github.com/rackerlabs/understack.git` |
 | `understack_ref` | UnderStack git reference | `HEAD` |
 | `deploy_ref` | Deployment repo git reference | `HEAD` |
-| `global.enabled` | Enable global cluster components | `true` |
-| `site.enabled` | Enable site cluster components | `true` |
+| `global.enabled` | Enable global cluster components | `false` |
+| `site.enabled` | Enable site cluster components | `false` |
 
 ### Example Values Files