Handle Windows and remote buffers using default formatters#357
Open
jkxyz wants to merge 1 commit into
Open
Conversation
Various fixes to ensure that the default formatters work over Tramp and on Windows: 1. Replace the apheleia-npx command with npx when the buffer is remote or running on Windows. This uses the built-in npx handling to lookup the binary, so npx never gets called. Since the apheleia-npx script isn't available on remote hosts, it makes sense to remove this. The same is done for Windows to capture the case of using WSL, in which case calling bash will enter WSL and so the script cannot be accessed using the Windows path. 2. Use local file name when returning binary path. 3. Don't use executable-find if the binary is already an absolute path. 4. Pass the -l option to sh to ensure that it loads the user's profile.
raxod502
reviewed
Mar 31, 2025
Comment on lines
+975
to
+979
| ;; Just use npx when buffer is remote or we're running on Windows, | ||
| ;; since in these cases bash won't be able to find the script | ||
| (when (and (member "apheleia-npx" command) | ||
| (or run-on-remote (eq system-type 'windows-nt))) | ||
| (setq command (cons 'npx (remove "apheleia-npx" command)))) |
Member
There was a problem hiding this comment.
This will be an issue for any of the scripts in the Apheleia scripts directory, just just the npx one. What would you think of having Apheleia copy the script to the remote host before first execution, if anything apheleia-prefixed is used in the command?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Various fixes to ensure that the default formatters work over Tramp
and on Windows:
Replace the apheleia-npx command with npx when the buffer is remote
or running on Windows. This uses the built-in npx handling to lookup
the binary, so npx never gets called. Since the apheleia-npx script
isn't available on remote hosts, it makes sense to remove this. The
same is done for Windows to capture the case of using WSL, in which
case calling bash will enter WSL and so the script cannot be accessed
using the Windows path.
Use local file name when returning binary path.
Don't use executable-find if the binary is already an absolute path.
Pass the -l option to sh to ensure that it loads the user's profile.