fix: detektAll findings

Author: wmontwe

build-plugin/plugin/src/main/kotlin/net/thunderbird/gradle/plugin/quality/detekt/DetektPlugin.kt

@@ -52,6 +52,10 @@ class DetektPlugin : Plugin<Project> {
     private fun Project.configureDetektTasks() {
         with(tasks) {
             withType<Detekt>().configureEach {
+                if (name.contains("androidHostTest", ignoreCase = true)) {
+                    enabled = false
+                }
+
                 jvmTarget = ProjectConfig.Compiler.jvmTarget.target
 
                 exclude(defaultExcludes)
@@ -66,6 +70,10 @@ class DetektPlugin : Plugin<Project> {
             }
 
             withType<DetektCreateBaselineTask>().configureEach {
+                if (name.contains("androidHostTest", ignoreCase = true)) {
+                    enabled = false
+                }
+
                 jvmTarget = ProjectConfig.Compiler.jvmTarget.target
 
                 exclude(defaultExcludes)
@@ -98,6 +106,7 @@ private val defaultExcludes = listOf(
     "**/.gradle/**",
     "**/.idea/**",
     "**/build/**",
+    "**/generated/**",
     ".github/**",
     "gradle/**",
 )

cli/weblate-cli/src/main/kotlin/net/thunderbird/cli/weblate/ComponentConfigDiff.kt

@@ -97,7 +97,12 @@ private class SetField(
         val actualValue = selector(actual)
 
         return if (expectedValue.toSet() != actualValue.toSet()) {
-            listDiff(name, expectedValue, actualValue, indentLevel)
+            listDiff(
+                name = name,
+                expected = expectedValue,
+                actual = actualValue,
+                indentLevel = indentLevel,
+            )
         } else {
             null
         }
@@ -142,7 +147,12 @@ private class MultilineField(
         val actualValue = selector(actual)
 
         return if (expectedValue != actualValue) {
-            multilineDiff(name, expectedValue, actualValue, indentLevel)
+            multilineDiff(
+                name = name,
+                expected = expectedValue,
+                actual = actualValue,
+                indentLevel = indentLevel,
+            )
         } else {
             null
         }

core/common/src/commonMain/kotlin/net/thunderbird/core/common/state/debug/StatePrettyPrinterVocabulary.kt

@@ -9,6 +9,7 @@ import net.thunderbird.core.common.state.debug.extension.prependIndent
  * Provides constants and formatting functions used by [StatePrettyPrinter] to produce
  * human-readable representations of state machine transitions and history dumps.
  */
+@Suppress("TooManyFunctions")
 internal object StatePrettyPrinterVocabulary {
     const val STATE_CHANGE_MARKER = "->"
     const val STATE_NO_CHANGE_MARKER = "⟳"

core/configstore/api/src/commonMain/kotlin/net/thunderbird/core/configstore/ConfigDefinition.kt

@@ -4,10 +4,13 @@ package net.thunderbird.core.configstore
  * A definition of how to manage a configuration for specific type.
  *
  * The id of the configuration is used as a unique identifier to distinguish it from other configurations and
- * is used by the [net.thunderbird.core.configstore.backend.ConfigBackendProvider] to retrieve the correct configuration backend.
+ * is used by the [net.thunderbird.core.configstore.backend.ConfigBackendProvider] to retrieve the correct
+ * configuration backend.
  *
- * This allows configurations to selectively share a backend, which can be useful for performance or organizational purposes.
- * It also allows for the creation of multiple configurations that can be managed independently, even if they share the same backend.
+ * This allows configurations to selectively share a backend, which can be useful for performance or organizational
+ * purposes.
+ * It also allows for the creation of multiple configurations that can be managed independently, even if they share
+ * the same backend.
  *
  * @param T The type of the configuration object.
  *
@@ -22,7 +25,8 @@ interface ConfigDefinition<T> {
     /**
      * The id of the configuration.
      *
-     * It is used by the [net.thunderbird.core.configstore.backend.ConfigBackendProvider] to retrieve the correct configuration backend.
+     * It is used by the [net.thunderbird.core.configstore.backend.ConfigBackendProvider] to retrieve the correct
+     * configuration backend.
      */
     val id: ConfigId
 

core/configstore/impl-backend/src/commonMain/kotlin/net/thunderbird/core/configstore/backend/DefaultDataStoreConfigBackend.kt

@@ -39,6 +39,7 @@ class DefaultDataStoreConfigBackend(
         config
     }
 
+    @Suppress("CyclomaticComplexMethod")
     override suspend fun update(keys: List<ConfigKey<*>>, transform: (Config) -> Config) {
         val current = read(keys).first()
         val updated = transform(current)

core/file/src/commonMain/kotlin/net/thunderbird/core/file/command/CopyCommand.kt

@@ -2,6 +2,9 @@ package net.thunderbird.core.file.command
 
 import com.eygraber.uri.Uri
 import kotlinx.io.Buffer
+import kotlinx.io.IOException
+import kotlinx.io.RawSink
+import kotlinx.io.RawSource
 import net.thunderbird.core.file.FileOperationError
 import net.thunderbird.core.file.FileSystemManager
 import net.thunderbird.core.file.WriteMode
@@ -15,46 +18,77 @@ internal class CopyCommand(
     private val destinationUri: Uri,
 ) : FileCommand<Unit> {
     override suspend fun invoke(fs: FileSystemManager): Outcome<Unit, FileOperationError> {
-        // Open endpoints
         val source = fs.openSource(sourceUri)
-            ?: return Outcome.Failure(
+        val sink = fs.openSink(destinationUri, WriteMode.Truncate)
+
+        return if (source == null) {
+            Outcome.Failure(
                 FileOperationError.Unavailable(sourceUri, "Unable to open source: $sourceUri"),
             )
-        val sink = fs.openSink(destinationUri, WriteMode.Truncate)
-            ?: return Outcome.Failure(
+        } else if (sink == null) {
+            Outcome.Failure(
                 FileOperationError.Unavailable(destinationUri, "Unable to open destination: $destinationUri"),
             )
+        } else {
+            copy(source, sink)
+        }
+    }
+
+    private fun copy(source: RawSource, sink: RawSink): Outcome<Unit, FileOperationError> {
+        val buffer = Buffer()
 
         return try {
-            val buffer = Buffer()
-            while (true) {
-                val read = try {
-                    source.readAtMostTo(buffer, BUFFER_SIZE)
-                } catch (e: Exception) {
-                    return Outcome.Failure(FileOperationError.ReadFailed(sourceUri, e.message), cause = e)
-                }
-                if (read <= 0L) break
-                try {
-                    sink.write(buffer, read)
-                } catch (e: Exception) {
-                    return Outcome.Failure(FileOperationError.WriteFailed(destinationUri, e.message), cause = e)
-                }
-            }
-            try {
-                sink.flush()
-            } catch (e: Exception) {
-                return Outcome.Failure(FileOperationError.WriteFailed(destinationUri, e.message), cause = e)
-            }
+            copyToSink(source, sink, buffer)
+            flushSink(sink)
             Outcome.Success(Unit)
-        } catch (e: Exception) {
+        } catch (e: FileOperationException) {
+            Outcome.Failure(e.error, cause = e.cause)
+        } catch (e: IOException) {
             Outcome.Failure(FileOperationError.Unknown(e.message), cause = e)
         } finally {
+            closeQuietly(source, sink)
+        }
+    }
+
+    private fun copyToSink(source: RawSource, sink: RawSink, buffer: Buffer) {
+        while (true) {
+            val read = try {
+                source.readAtMostTo(buffer, BUFFER_SIZE)
+            } catch (e: IOException) {
+                throw FileOperationException(FileOperationError.ReadFailed(sourceUri, e.message), e)
+            }
+
+            if (read <= 0L) break
+
             try {
-                source.close()
-            } catch (_: Exception) {}
-            try {
-                sink.close()
-            } catch (_: Exception) {}
+                sink.write(buffer, read)
+            } catch (e: IOException) {
+                throw FileOperationException(FileOperationError.WriteFailed(destinationUri, e.message), e)
+            }
+        }
+    }
+
+    private fun flushSink(sink: RawSink) {
+        try {
+            sink.flush()
+        } catch (e: IOException) {
+            throw FileOperationException(FileOperationError.WriteFailed(destinationUri, e.message), e)
+        }
+    }
+
+    private class FileOperationException(
+        val error: FileOperationError,
+        override val cause: Throwable?,
+    ) : Exception(error.toString(), cause)
+
+    private fun closeQuietly(source: AutoCloseable?, sink: AutoCloseable?) {
+        try {
+            source?.close()
+        } catch (_: Exception) {
+        }
+        try {
+            sink?.close()
+        } catch (_: Exception) {
         }
     }
 

core/file/src/commonMain/kotlin/net/thunderbird/core/file/command/CreateDirectoriesCommand.kt

@@ -1,6 +1,7 @@
 package net.thunderbird.core.file.command
 
 import com.eygraber.uri.Uri
+import kotlinx.io.IOException
 import net.thunderbird.core.file.FileOperationError
 import net.thunderbird.core.file.FileSystemManager
 import net.thunderbird.core.outcome.Outcome
@@ -15,7 +16,7 @@ internal class CreateDirectoriesCommand(
         return try {
             fs.createDirectories(dirUri)
             Outcome.Success(Unit)
-        } catch (e: Exception) {
+        } catch (e: IOException) {
             Outcome.Failure(
                 error = FileOperationError.Unavailable(dirUri, e.message ?: "Unable to create directory: $dirUri"),
                 cause = e,

core/file/src/jvmMain/kotlin/net/thunderbird/core/file/JvmFileSystemManager.kt

@@ -46,11 +46,12 @@ class JvmFileSystemManager : FileSystemManager {
             if (!file.delete() && file.exists()) {
                 throw IOException("Unable to delete file at: $uri")
             }
-        } catch (error: Exception) {
+        } catch (error: IOException) {
             throw IOException("Unable to delete file at: $uri", error)
         }
     }
 
+    @Suppress("TooGenericExceptionCaught")
     override fun createDirectories(uri: Uri) {
         try {
             val file = File(uri.toURI())

core/logging/api/src/commonMain/kotlin/net/thunderbird/core/logging/LogLevel.kt

@@ -14,6 +14,7 @@ package net.thunderbird.core.logging
  *
  * @param priority The priority of the log level, where a lower priority indicates a more verbose level.
  */
+@Suppress("MagicNumber")
 enum class LogLevel(
     val priority: Int,
 ) {

core/logging/impl-legacy/src/commonMain/kotlin/net/thunderbird/core/logging/legacy/Log.kt

@@ -6,7 +6,8 @@ import net.thunderbird.core.logging.LogTag
 import net.thunderbird.core.logging.Logger
 
 /**
- * A static logging utility that implements [net.thunderbird.core.logging.Logger] and delegates to a [net.thunderbird.core.logging.Logger] implementation.
+ * A static logging utility that implements [net.thunderbird.core.logging.Logger] and delegates to a
+ * [net.thunderbird.core.logging.Logger] implementation.
  *
  * You can initialize it in your application startup code, for example:
  *
@@ -27,6 +28,7 @@ import net.thunderbird.core.logging.Logger
     message = "Use a net.thunderbird.core.logging.Logger instance via dependency injection instead. " +
         "This class will be removed in a future release.",
 )
+@Suppress("TooManyFunctions")
 object Log : Logger {
 
     lateinit var logger: Logger
@@ -143,6 +145,7 @@ object Log : Logger {
         logger.error(message = { formatMessage(message, args) }, throwable = t)
     }
 
+    @Suppress("SpreadOperator", "TooGenericExceptionCaught")
     private fun formatMessage(message: String?, args: Array<out Any?>): String {
         return if (message == null) {
             ""