Skip to content

Fix broadcasting and test on julia v1.9#1187

Open
tiemvanderdeure wants to merge 8 commits into
rafaqz:mainfrom
tiemvanderdeure:broadcast_v1_9
Open

Fix broadcasting and test on julia v1.9#1187
tiemvanderdeure wants to merge 8 commits into
rafaqz:mainfrom
tiemvanderdeure:broadcast_v1_9

Conversation

@tiemvanderdeure

Copy link
Copy Markdown
Collaborator

closes #1186

@codecov

codecov Bot commented Apr 28, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.71%. Comparing base (8955b81) to head (df7e92a).
⚠️ Report is 3 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (8955b81) and HEAD (df7e92a). Click for more details.

HEAD has 4 uploads less than BASE
Flag BASE (8955b81) HEAD (df7e92a)
6 2
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1187      +/-   ##
==========================================
- Coverage   86.98%   80.71%   -6.28%     
==========================================
  Files          61       61              
  Lines        5849     5845       -4     
==========================================
- Hits         5088     4718     -370     
- Misses        761     1127     +366     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tiemvanderdeure

tiemvanderdeure commented Apr 28, 2026

Copy link
Copy Markdown
Collaborator Author

Hm so what is causing all these errors is that mapping over tuples with unequal number of elements like map(+, (1,), (2,3)) errors on 1.9 but works from 1.10 on.

Apparently it is a common thing - this error is in DiskArrays (which also has a 1.9 compat but tests on 1.10)

@tiemvanderdeure

Copy link
Copy Markdown
Collaborator Author

Okay since I don't know when my PR to fix CategoricalArrays on 1.9 will be merged I'm just going to skip those tests on 1.9 so we can make sure tests pass, merge this PR, and move on.

Once this is merged we should make a patch release and then probably require 1.10 just because it is the LTS?

@tiemvanderdeure

Copy link
Copy Markdown
Collaborator Author

Aah this is just so annoying. Now it's failing on all Makie tests. Maybe we should require a higher Makie version than we do?.

The windows run on Julia 1 passed so I'm pretty sure this didn't break anything. I really don't feel like debugging tests just for the sake of it.

How do you feel about just merging this so we can move on @rafaqz ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

DimensionalData 0.30 fails to precompile on Julia 1.9: type Broadcasted has no field style

1 participant