Fix broadcasting and test on julia v1.9#1187
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests.
Additional details and impacted files@@ Coverage Diff @@
## main #1187 +/- ##
==========================================
- Coverage 86.98% 80.71% -6.28%
==========================================
Files 61 61
Lines 5849 5845 -4
==========================================
- Hits 5088 4718 -370
- Misses 761 1127 +366 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Hm so what is causing all these errors is that mapping over tuples with unequal number of elements like Apparently it is a common thing - this error is in DiskArrays (which also has a 1.9 compat but tests on 1.10) |
|
Okay since I don't know when my PR to fix CategoricalArrays on 1.9 will be merged I'm just going to skip those tests on 1.9 so we can make sure tests pass, merge this PR, and move on. Once this is merged we should make a patch release and then probably require 1.10 just because it is the LTS? |
|
Aah this is just so annoying. Now it's failing on all Makie tests. Maybe we should require a higher Makie version than we do?. The windows run on Julia 1 passed so I'm pretty sure this didn't break anything. I really don't feel like debugging tests just for the sake of it. How do you feel about just merging this so we can move on @rafaqz ? |
closes #1186