experiment with best_manifold implementation here#896
Draft
asinghvi17 wants to merge 1 commit into
Draft
Conversation
Collaborator
Author
|
It looks like we will have a problem with detecting things that don't have a backing ellipsoid - |
Collaborator
|
I get the point here but this also seems quite fragile and blackboxy. We could also just throw a more informative errors that point users towards passing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
seems we need this now, will move the code to GeometryOps / Proj / GFT / wherever later but want to at least get a working implementation here.
this is the way to solve #895