Establish React component testing patterns for geoset-map-chart (#345)

* #310 establish React component testing patterns for geoset-map-chart plugin

Add comprehensive test suite covering utility functions, components, and hooks:
- MultiLegend component tests with theme provider wrapper
- colors.ts: computeSizeScale, toRGBA, rgbaArrayToHex, applyColorMapping,
  computeMetricColorScaleUnified, getFeatureColor, percentile helpers, lerp functions
- colorsFallback.ts: hasValidFill, normalizeRGBA, normalizeColorToHex,
  rgbaArrayToCssString, rgbaObjectToArray
- dataProcessing.ts: getBreakPoints, parseRawFeatures, normalizeNullCategory,
  getGeometryType
- fitViewport.ts: isValidViewport, toNumericViewport, fitViewport,
  calculateAutozoomViewport
- convertToGeoJson.ts: convertToGeoJSONFeature (GeoJSON, WKT, edge cases)
- computeBoundsFromPoints.ts: bounds computation and expansion
- hooks.ts and legendHelpers.ts: full coverage
- Extract legendHelpers utility from MultiLegend for testability
- Add shared test fixtures and theme-wrapped render helper

11 test suites, 218 tests, src/utils coverage raised from 14.7% to 49.2%

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* #310 expand test coverage for geoset-map-chart utility modules

Add new test suites and expand existing ones:
- validateLayerType: full coverage of geometry type mapping
- measureDistance: Haversine formula and imperial formatting
- safeStringify: circular reference handling and prettyStringify
- liveViewportStore: set/get round-trip
- formatNumber: legend number formatting with K/M/B suffixes
- colors.ts: cssToRgbaArray, normalizeColorInput, addColor,
  normalizeCategoryColorMapping object branch, breakpoint edge cases
- dataProcessing.ts: getBreakPointColorScaler and getBuckets

Coverage raised from 43% to 57% statements for src/utils/

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* Merge conflict fix

* fix: deduplicate formatLegendNumber test cases after merge conflict

* #310 add Legend component tests and fix TS errors in test files

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* #310 expand GeoSetLayer tests with getLayer and getLayerStates coverage

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* fix: address PR #339 review feedback on test quality

- Extract duplicated svgIcons jest.mock blocks into shared test/mocks/svgIcons.ts
- Restore deck.gl rendering-order comments in sorting tests
- Remove unfailable and trivial tests (liveViewportStore, safeStringify)
- Consolidate normalizeNullCategory tests with it.each
- Fix brittle computeSizeScale midpoint assertion
- Add edge-case tests: getDefaultColors undefined props, applyCategoryEnabledState
  falsy values, MULTI WKT geometries, unrecognized geoJsonLayer, invalid Legend position
- Add explanatory comment for cssToRgbaArray canvas mocking

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* fix: cast invalid position string to any for TS compatibility

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: lhawkins <lhawkins@teamraft.com>
Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
Co-authored-by: Ethan Bienstock <ethan.bienstock@acf.hhs.gov>

Author: 4 people

superset-frontend/jest.config.js

@@ -56,7 +56,7 @@ module.exports = {
   ],
   coverageReporters: ['lcov', 'json-summary', 'html', 'text'],
   transformIgnorePatterns: [
-    'node_modules/(?!d3-(interpolate|color|time|scale)|@mapbox/tiny-sdf|remark-gfm|(?!@ngrx|(?!deck.gl)|d3-scale)|markdown-table|micromark-*.|decode-named-character-reference|character-entities|mdast-util-*.|unist-util-*.|ccount|escape-string-regexp|nanoid|@rjsf/*.|sinon|echarts|zrender|fetch-mock|pretty-ms|parse-ms|ol|@babel/runtime|@emotion|cheerio|cheerio/lib|parse5|dom-serializer|entities|htmlparser2|rehype-sanitize|hast-util-sanitize|unified|unist-.*|hast-.*|rehype-.*|remark-.*|mdast-.*|micromark-.*|parse-entities|property-information|space-separated-tokens|comma-separated-tokens|bail|devlop|zwitch|longest-streak|geostyler|geostyler-.*|react-error-boundary|react-json-tree|react-base16-styling|lodash-es)',
+    'node_modules/(?!d3-(interpolate|color|time|scale|array)|internmap|@mapbox/tiny-sdf|remark-gfm|(?!@ngrx|(?!deck.gl)|d3-scale)|markdown-table|micromark-*.|decode-named-character-reference|character-entities|mdast-util-*.|unist-util-*.|ccount|escape-string-regexp|nanoid|@rjsf/*.|sinon|echarts|zrender|fetch-mock|pretty-ms|parse-ms|ol|@babel/runtime|@emotion|cheerio|cheerio/lib|parse5|dom-serializer|entities|htmlparser2|rehype-sanitize|hast-util-sanitize|unified|unist-.*|hast-.*|rehype-.*|remark-.*|mdast-.*|micromark-.*|parse-entities|property-information|space-separated-tokens|comma-separated-tokens|bail|devlop|zwitch|longest-streak|geostyler|geostyler-.*|react-error-boundary|react-json-tree|react-base16-styling|lodash-es)',
   ],
   preset: 'ts-jest',
   transform: {

superset-frontend/plugins/geoset-map-chart/src/GeoSetMultiMap/Multi.tsx

@@ -54,15 +54,7 @@ import { fetchMapboxApiKey, getCachedMapboxApiKey } from '../utils/mapboxApi';
 import { multiChartMigration } from '../utils/migrationApi';
 import ClickPopupBox, { ClickedFeatureInfo } from '../components/ClickPopupBox';
 import { setLiveViewport } from '../utils/liveViewportStore';
-// Apply enabled state to legend categories based on visibility map
-const applyCategoryEnabledState = (
-  categories: CategoryEntry[] | undefined,
-  visibility: Record<string, boolean>,
-): CategoryEntry[] | undefined =>
-  categories?.map(cat => ({
-    ...cat,
-    enabled: visibility[cat.label] !== false,
-  }));
+import { applyCategoryEnabledState } from '../utils/legendHelpers';
 
 // Utility to convert snake_case or camelCase to Title Case
 const toTitleCase = (str: string) =>

superset-frontend/plugins/geoset-map-chart/src/components/MultiLegend.tsx

@@ -7,6 +7,7 @@ import { Swatch } from '../utils/legendSwatch';
 import { formatBoundLabel } from '../utils/formatNumber';
 import GraduatedIcons from './GraduatedIcons';
 import CategorySizeGrid, { CategorySizeGridItem } from './CategorySizeGrid';
+import { getDefaultColors } from '../utils/legendHelpers';
 
 export type MultiLegendProps = {
   legendGroups: LegendGroup[];
@@ -206,27 +207,6 @@ const IndeterminateCheckbox: React.FC<{
   );
 };
 
-const getDefaultColors = (
-  layer: LegendEntry,
-): { fill: RGBAColor; stroke: RGBAColor } => {
-  if (layer.simpleStyle) {
-    return {
-      fill: layer.simpleStyle.fillColor,
-      stroke: layer.simpleStyle.strokeColor,
-    };
-  }
-  if (layer.metric) {
-    return { fill: layer.metric.startColor, stroke: layer.metric.startColor };
-  }
-  if (layer.categories && layer.categories.length > 0) {
-    return {
-      fill: layer.categories[0].fillColor,
-      stroke: layer.categories[0].strokeColor,
-    };
-  }
-  return { fill: [0, 122, 135, 255], stroke: [0, 122, 135, 255] };
-};
-
 const LegendEntryContent: React.FC<{
   sliceId: string;
   legendEntry: LegendEntry;

superset-frontend/plugins/geoset-map-chart/src/utils/legendHelpers.ts

@@ -0,0 +1,34 @@
+import type { RGBAColor } from './colors';
+import type { LegendEntry, CategoryEntry } from '../types';
+
+/** Resolve the default fill/stroke colors for a legend entry. */
+export const getDefaultColors = (
+  layer: LegendEntry,
+): { fill: RGBAColor; stroke: RGBAColor } => {
+  if (layer.simpleStyle) {
+    return {
+      fill: layer.simpleStyle.fillColor,
+      stroke: layer.simpleStyle.strokeColor,
+    };
+  }
+  if (layer.metric) {
+    return { fill: layer.metric.startColor, stroke: layer.metric.startColor };
+  }
+  if (layer.categories && layer.categories.length > 0) {
+    return {
+      fill: layer.categories[0].fillColor,
+      stroke: layer.categories[0].strokeColor,
+    };
+  }
+  return { fill: [0, 122, 135, 255], stroke: [0, 122, 135, 255] };
+};
+
+/** Apply enabled state to legend categories based on visibility map. */
+export const applyCategoryEnabledState = (
+  categories: CategoryEntry[] | undefined,
+  visibility: Record<string, boolean>,
+): CategoryEntry[] | undefined =>
+  categories?.map(cat => ({
+    ...cat,
+    enabled: visibility[cat.label] !== false,
+  }));