Commit f49635d
committed
Compare parquet-mr version with SemanticVersion in ValidInt96Stats
String.compareTo is lexicographic: "1.15.1".compareTo("1.16.0") returns -1,
which incorrectly rejected parquet-mr 1.15.1 (caught by testParquetMrValid)
and also accepted hypothetical pre-1.15 versions like 1.5.0 (since '5' > '1'
at position 2). Use SemanticVersion compareTo with a 1.15.0 lower bound;
strict > so 1.15.0 itself stays invalid, matching testParquetMrInvalid.1 parent ad7c4ec commit f49635d
1 file changed
Lines changed: 6 additions & 1 deletion
Lines changed: 6 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
34 | 34 | | |
35 | 35 | | |
36 | 36 | | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
37 | 41 | | |
38 | 42 | | |
39 | 43 | | |
| |||
50 | 54 | | |
51 | 55 | | |
52 | 56 | | |
53 | | - | |
| 57 | + | |
| 58 | + | |
54 | 59 | | |
55 | 60 | | |
56 | 61 | | |
| |||
0 commit comments