Skip to content

Commit 0540a9d

Browse files
awoll-bdaiexploy-bot
authored andcommitted
Remove most ignored checks from ruff config (#85)
### What change is being made Remove ignored checks from ruff config. ### Why this change is being made Better checks. ### Tested Run tasks for linting and formatting. GitOrigin-RevId: 99a91380496b278f03ca43e3281297675cc6001c
1 parent 2d66100 commit 0540a9d

2 files changed

Lines changed: 18 additions & 24 deletions

File tree

.ruff.toml

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -18,16 +18,9 @@ select = [
1818
]
1919

2020
ignore = [
21-
"E501", # line-too-long (formatter handles this)
22-
"E402", # module-level-import-not-at-top-of-file (needed for some frameworks)
23-
"F401", # unused-import (may be for re-export)
24-
"F841", # unused-variable (sometimes intentional)
21+
"E501", # line-too-long (formatter handles code lines; comments/docstrings must be manual)
2522
]
2623

27-
[lint.per-file-ignores]
28-
"__init__.py" = ["F401"] # Allow unused imports in __init__.py
29-
"examples/exporter_scripts/export_isaaclab.py" = ["E402", "F401", "F403"] # Allow import flexibility for isaaclab
30-
3124
[format]
3225
quote-style = "double"
3326
indent-style = "space"

examples/exporter_scripts/isaaclab/export_isaaclab.py

Lines changed: 17 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,8 @@
11
# Copyright (c) 2026 Robotics and AI Institute LLC dba RAI Institute. All rights reserved.
2+
"""Launch Isaac Sim Simulator first."""
3+
24
from __future__ import annotations
35

4-
"""Launch Isaac Sim Simulator first."""
56
import argparse
67
import pathlib
78
from typing import TYPE_CHECKING
@@ -49,26 +50,26 @@ def make_simulation_app() -> tuple[SimulationApp, argparse.Namespace]:
4950

5051

5152
# Import tasks to register environments
52-
import isaaclab_tasks.manager_based.locomotion.velocity.config.anymal_c # noqa: F401
53-
import isaaclab_tasks.manager_based.locomotion.velocity.config.g1 # noqa: F401
54-
import torch
55-
from isaaclab.sim import SimulationContext
56-
from isaaclab_rl.rsl_rl import RslRlVecEnvWrapper
57-
from isaaclab_tasks.utils import parse_env_cfg
58-
from rsl_rl.algorithms.ppo import PPO
59-
from rsl_rl.runners import OnPolicyRunner
60-
61-
from exploy.exporter.core.evaluator import evaluate
62-
from exploy.exporter.core.exporter import export_environment_as_onnx
63-
from exploy.exporter.core.session_wrapper import SessionWrapper
64-
from exploy.exporter.frameworks.isaaclab import (
53+
import isaaclab_tasks.manager_based.locomotion.velocity.config.anymal_c # noqa: F401, E402
54+
import isaaclab_tasks.manager_based.locomotion.velocity.config.g1 # noqa: F401, E402
55+
import torch # noqa: E402
56+
from isaaclab.sim import SimulationContext # noqa: E402
57+
from isaaclab_rl.rsl_rl import RslRlVecEnvWrapper # noqa: E402
58+
from isaaclab_tasks.utils import parse_env_cfg # noqa: E402
59+
from rsl_rl.algorithms.ppo import PPO # noqa: E402
60+
from rsl_rl.runners import OnPolicyRunner # noqa: E402
61+
62+
from exploy.exporter.core.evaluator import evaluate # noqa: E402
63+
from exploy.exporter.core.exporter import export_environment_as_onnx # noqa: E402
64+
from exploy.exporter.core.session_wrapper import SessionWrapper # noqa: E402
65+
from exploy.exporter.frameworks.isaaclab import ( # noqa: E402
6566
environments, # noqa: F401
6667
inputs,
6768
memory,
6869
outputs,
6970
)
70-
from exploy.exporter.frameworks.isaaclab.actor import make_exportable_actor
71-
from exploy.exporter.frameworks.isaaclab.env import IsaacLabExportableEnvironment
71+
from exploy.exporter.frameworks.isaaclab.actor import make_exportable_actor # noqa: E402
72+
from exploy.exporter.frameworks.isaaclab.env import IsaacLabExportableEnvironment # noqa: E402
7273

7374

7475
def export_isaaclab(

0 commit comments

Comments
 (0)