Add localization interface and cancelable navigation methods#40
Draft
sktometometo wants to merge 21 commits into
Draft
Add localization interface and cancelable navigation methods#40sktometometo wants to merge 21 commits into
sktometometo wants to merge 21 commits into
Conversation
sktometometo
force-pushed
the
PR/add-cancelable-navigation-methods
branch
from
June 30, 2023 00:03
4bd3616 to
fae31b5
Compare
sktometometo
marked this pull request as ready for review
June 30, 2023 01:42
sktometometo
requested review from
amessing-bdai,
heuristicus and
jbarry-bdai
as code owners
June 30, 2023 01:42
Contributor
Author
|
Checked with our robot. |
sktometometo
force-pushed
the
PR/add-cancelable-navigation-methods
branch
from
June 30, 2023 01:44
674b514 to
cbbf0a3
Compare
heuristicus
reviewed
Jun 30, 2023
heuristicus
reviewed
Jun 30, 2023
heuristicus
reviewed
Jun 30, 2023
heuristicus
reviewed
Jun 30, 2023
heuristicus
reviewed
Jun 30, 2023
heuristicus
reviewed
Jun 30, 2023
Contributor
Author
|
Thanks for review! I will update the branch. |
sktometometo
marked this pull request as draft
July 1, 2023 06:12
sktometometo
force-pushed
the
PR/add-cancelable-navigation-methods
branch
from
July 1, 2023 06:40
64b9c6e to
b7ac5a2
Compare
Contributor
Author
|
Rebase this branch to #48 to support |
sktometometo
marked this pull request as ready for review
July 4, 2023 00:56
…t_id and add result output.
Co-authored-by: Michal Staniaszek <m.staniaszek@gmail.com>
Co-authored-by: Michal Staniaszek <m.staniaszek@gmail.com>
…gate_to_command to RobotCommandData() class
sktometometo
force-pushed
the
PR/add-cancelable-navigation-methods
branch
from
July 4, 2023 05:27
b7ac5a2 to
5bc6463
Compare
Contributor
Author
|
Pause this PR until #44 is merged. |
sktometometo
marked this pull request as draft
July 9, 2023 23:11
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on pull requests below.
This PR introduces features below.
_set_localization_waypoint()from*argtowaypoint_idset_localization_fiducial()andset_localization_waypoint())navigate_tointerface_start_navigate_to()and_cancel_navigate_to()start_navigation()andcancel_navigation()_last_navigate_to_commandvalue to indicatenavigate_tois running or not_is_movingupdateChecked with a robot by