fix: correction du blocage BCASL et centralisation des helpers de runtime

- Centralise is_noninteractive et is_cli_mode dans Ui/Cli/runtime.py.
- Corrige le blocage de la compilation en GUI quand BCASL est désactivé.
- Nettoyage des importations et de la logique redondante dans le SDK et l'UI.
- Amélioration de la gestion des rapports 'désactivés' dans le Loader BCASL.

Co-authored-by: Cursor <cursoragent@cursor.com>

Author: raidos23

Plugins_SDK/GeneralContext/Dialog.py

@@ -23,11 +23,10 @@
 from rich.console import Console
 
 # Import des classes et fonctions de Core.dialogs
+from Ui.Cli.runtime import is_cli_mode, is_noninteractive
 from Ui.Gui.WidgetsCreator import (
     InstallAuth,
     ProgressDialog,
-    _is_cli_mode,
-    _is_noninteractive,
     _redact_secrets,
     show_msgbox,
     sys_msgbox_for_installing,
@@ -43,7 +42,7 @@ def __init__(self):
         colorama.init()
         self.console = Console()
         self.plugin_id: Optional[str] = None
-        if not _is_cli_mode() and not _is_noninteractive():
+        if not is_cli_mode() and not is_noninteractive():
             self._ensure_qt_context()
 
     def _ensure_qt_context(self) -> None:
@@ -53,7 +52,7 @@ def _ensure_qt_context(self) -> None:
             import os
 
             # CLI and headless runs must stay on Rich, never bootstrap Qt here.
-            if _is_cli_mode() or _is_noninteractive():
+            if is_cli_mode() or is_noninteractive():
                 return
 
             # Skip if already initialized or in explicit headless mode
@@ -184,7 +183,7 @@ def progress(
         Uses Core.dialogs.ProgressDialog when GUI is available,
         otherwise returns a Rich-based console fallback.
         """
-        use_rich = _is_cli_mode() or _is_noninteractive()
+        use_rich = is_cli_mode() or is_noninteractive()
         if not use_rich:
             try:
                 from PySide6.QtWidgets import QApplication

Ui/Cli/helpers.py

@@ -555,6 +555,17 @@ def append(self, msg: str):
         # report is None if BCASL is disabled or failed silently
         return True
 
+    if isinstance(report, dict):
+        try:
+            from bcasl.Loader import is_bcasl_disabled_report
+
+            if is_bcasl_disabled_report(report):
+                return True
+        except Exception:
+            pass
+        if "ok" in report:
+            return bool(report.get("ok"))
+
     if hasattr(report, "ok"):
         if not getattr(report, "ok"):
             error("BCASL reported security or validation failures.")

Ui/Cli/interactive.py

@@ -14,10 +14,9 @@
 
 def _is_noninteractive_env() -> bool:
     try:
-        v = os.environ.get("PYCOMPILER_NONINTERACTIVE")
-        if v is None:
-            return False
-        return str(v).strip().lower() not in ("", "0", "false", "no")
+        from Ui.Cli.runtime import is_noninteractive
+
+        return is_noninteractive()
     except Exception:
         return False
 

Ui/Cli/runtime.py

@@ -262,6 +262,22 @@ def is_cli_mode() -> bool:
         return False
 
 
+def is_noninteractive() -> bool:
+    """True when prompts must not block (CI, headless plugin workers, etc.)."""
+    try:
+        v = os.environ.get("PYCOMPILER_NONINTERACTIVE")
+        if v is None:
+            return False
+        return str(v).strip().lower() not in ("", "0", "false", "no")
+    except Exception:
+        return False
+
+
+def use_rich_dialogs() -> bool:
+    """Use Rich console dialogs instead of Qt message boxes."""
+    return is_cli_mode() or is_noninteractive()
+
+
 def install_runtime(app_version: str, enable_qt: bool = True) -> None:
     ensure_sys_path()
     configure_logging()

Ui/Gui/Compilation/helpers.py

@@ -87,6 +87,16 @@ def bcasl_report_allows_compile(gui_instance, report) -> bool:
     """Return True when BCASL pre-compile report allows compilation to continue."""
     try:
         if report is None:
+            try:
+                from pathlib import Path
+
+                from bcasl.Loader import _is_bcasl_enabled
+
+                ws = getattr(gui_instance, "workspace_dir", None)
+                if ws and not _is_bcasl_enabled(Path(ws).resolve()):
+                    return True
+            except Exception:
+                pass
             log_i18n_level(
                 gui_instance,
                 "error",
@@ -96,9 +106,15 @@ def bcasl_report_allows_compile(gui_instance, report) -> bool:
             return False
 
         if isinstance(report, dict):
-            status = str(report.get("status", "")).strip().lower()
-            if status in {"disabled", "skipped"}:
-                return True
+            try:
+                from bcasl.Loader import is_bcasl_disabled_report
+
+                if is_bcasl_disabled_report(report):
+                    return True
+            except Exception:
+                status = str(report.get("status", "")).strip().lower()
+                if status in {"disabled", "skipped"}:
+                    return True
             if "ok" in report:
                 ok = bool(report.get("ok"))
                 if not ok:

Ui/Gui/Dialogs/BcaslDialog.py

@@ -876,6 +876,7 @@ def request_cancel(self) -> None:
     def run(self) -> None:
         try:
             from bcasl.Loader import (
+                BCASL_DISABLED_REPORT,
                 _is_bcasl_enabled,
                 _load_workspace_config,
                 _run_bcasl_sync,
@@ -884,7 +885,7 @@ def run(self) -> None:
             # 1. Vérifier si BCASL est activé (en arrière-plan)
             if not _is_bcasl_enabled(self.workspace_root):
                 self.log.emit("BCASL disabled in ark.yml. Skipping execution\n")
-                self.finished.emit({"status": "disabled"})
+                self.finished.emit(dict(BCASL_DISABLED_REPORT))
                 return
 
             # 2. Charger la config si non fournie (en arrière-plan)
@@ -927,7 +928,17 @@ def on_log(self, s: str) -> None:
     @Slot(object)
     def on_finished(self, rep) -> None:
         try:
-            if rep and hasattr(self._gui, "log") and self._gui.log is not None:
+            try:
+                from bcasl.Loader import is_bcasl_disabled_report
+            except Exception:
+                is_bcasl_disabled_report = lambda _r: False  # type: ignore[assignment,misc]
+
+            if (
+                rep
+                and not is_bcasl_disabled_report(rep)
+                and hasattr(self._gui, "log")
+                and self._gui.log is not None
+            ):
                 self._gui.log.append("BCASL - Rapport:\n")
                 for item in rep:
                     try:
@@ -1154,8 +1165,13 @@ def run_pre_compile_async(
             return
         workspace_root = Path(self.workspace_dir).resolve()
 
-        from bcasl.Loader import (_get_plugins_dir, _is_bcasl_enabled,
-                                  _run_bcasl_sync, _load_workspace_config)
+        from bcasl.Loader import (
+            BCASL_DISABLED_REPORT,
+            _get_plugins_dir,
+            _is_bcasl_enabled,
+            _load_workspace_config,
+            _run_bcasl_sync,
+        )
 
         # Étape 0: Vérifier si BCASL est activé globalement via ark.yml
         if not _is_bcasl_enabled(workspace_root):
@@ -1166,7 +1182,7 @@ def run_pre_compile_async(
                 pass
             if callable(on_done):
                 try:
-                    on_done(None)
+                    on_done(dict(BCASL_DISABLED_REPORT))
                 except Exception:
                     pass
             return

Ui/Gui/WidgetsCreator.py

@@ -130,38 +130,23 @@ def _redact_secrets(text: str) -> str:
 
 def _is_noninteractive() -> bool:
     """Check if running in non-interactive mode."""
-    try:
-        import os
+    from Ui.Cli.runtime import is_noninteractive
 
-        v = os.environ.get("PYCOMPILER_NONINTERACTIVE")
-        if v is None:
-            return False
-        return str(v).strip().lower() not in ("", "0", "false", "no")
-    except Exception:
-        return False
+    return is_noninteractive()
 
 
 def _is_cli_mode() -> bool:
     """True when ARK CLI is active: plugins/dialogs must use Rich, not Qt."""
-    try:
-        from Ui.Cli.runtime import is_cli_mode
+    from Ui.Cli.runtime import is_cli_mode
 
-        return is_cli_mode()
-    except Exception:
-        try:
-            import os
-
-            v = os.environ.get("PYCOMPILER_CLI")
-            if v is None:
-                return False
-            return str(v).strip().lower() not in ("", "0", "false", "no")
-        except Exception:
-            return False
+    return is_cli_mode()
 
 
 def _use_rich_dialogs() -> bool:
     """Use Rich console dialogs instead of Qt message boxes."""
-    return _is_cli_mode() or _is_noninteractive()
+    from Ui.Cli.runtime import use_rich_dialogs
+
+    return use_rich_dialogs()
 
 
 def _qt_active_parent():

bcasl/Loader.py

@@ -38,6 +38,16 @@
 from .executor import BCASL
 from .tagging import compute_tag_order
 
+BCASL_DISABLED_REPORT: dict[str, Any] = {"status": "disabled", "ok": True}
+
+
+def is_bcasl_disabled_report(report: Any) -> bool:
+    """Return True when BCASL was skipped because it is disabled in ark.yml."""
+    if not isinstance(report, dict):
+        return False
+    return str(report.get("status", "")).strip().lower() in {"disabled", "skipped"}
+
+
 # --- Utilitaires ---
 
 
@@ -483,7 +493,7 @@ def run_pre_compile(self, build_context: Optional[Any] = None) -> Optional[objec
                     self.log.append("BCASL désactivé dans ark.yml. Exécution ignorée\n")
             except Exception:
                 pass
-            return None
+            return dict(BCASL_DISABLED_REPORT)
 
         Plugins_dir = _get_plugins_dir()
         cfg = _load_workspace_config(workspace_root)

todo.md

@@ -5,18 +5,4 @@
 - [x] ecrire des tests unitaires.
 - [x] renforcement et blocage immédiat du build en cas d'absence d'Internet lors de l'installation des outils.
 
-- [] [INFO] Thème appliqué : Mint Light (mint_light.qss)
-[INFO] Langue appliquée : Français
-[INFO] Language applied: Deutsch
-[INFO] Theme applied: Dark (dark.qss)
-[INFO] Theme applied: Light (light.qss)
-[STATE] Exclusion applied: 402 file(s) excluded according to ark.yml
-[INFO] 🔒 Generating build lock file...
-[INFO] Starting pre-compilation phase (BCASL)...
-[INFO] Pre-compilation (BCASL) if enabled...
-
-BCASL désactivé dans ark.yml. Exécution ignorée
-[ERROR] BCASL failed or returned no report. Compilation blocked.
-[ERROR] BCASL validation failed. Compilation cannot continue.
-
-ce probleme c'est produit en gui, normalemnt comme il est desactiver la compialtion doit ce lancer sans bcasl mais ici il bloque.
+- [x] GUI : ne plus bloquer la compilation quand BCASL est désactivé dans ark.yml (rapport `disabled` au lieu de `None`).