refactor: Enhance UI loading process and improve error handling in BCASLStudioWindow

Author: PyCompiler ARK++

bcasl/only_mod/widgets/main_window.py

@@ -80,8 +80,6 @@ def run(self):
 class BCASLStudioWindow(QMainWindow):
     def __init__(self):
         super().__init__()
-        self.setWindowTitle("BCASL Studio (Standalone)")
-        self.resize(1400, 900)
         self.workspace: Optional[Path] = None
         self.plugins_dir: Optional[Path] = None
         self.cfg = None
@@ -90,69 +88,95 @@ def __init__(self):
 
         self._load_ui_from_designer()
         self._wire_menu_from_ui()
-        self._normalize_tab_positions()
         self._wire_logic()
 
     # ---------- UI loading from Designer ----------
     def _load_ui_from_designer(self):
+        # Load the .ui into a temporary QMainWindow, then copy its full state/layout into this subclass instance.
         loader = QUiLoader()
         ui_path = Path(__file__).resolve().parents[1] / "ui" / "studio.ui"
         f = QFile(str(ui_path))
         if not f.open(QFile.ReadOnly):
             raise RuntimeError(f"Cannot open UI file: {ui_path}")
-        # Load without parenting to avoid premature deletions; keep strong ref
-        w = loader.load(f)
-        f.close()
-        if w is None:
-            raise RuntimeError("Failed to load UI")
-        self._ui_loaded = w  # keep strong reference to prevent GC/deletion
-        # Adopt menubar/statusbar/central widget and docks
         try:
-            from PySide6.QtWidgets import QMenuBar, QStatusBar
-            mb = w.findChild(QMenuBar, "menubar")
-            if mb:
-                self.setMenuBar(mb)
-            sb = w.findChild(QStatusBar, "statusbar")
-            if sb:
-                self.setStatusBar(sb)
-        except Exception:
-            pass
-        cw = w.findChild(QWidget, "centralwidget")
-        if cw:
-            self.setCentralWidget(cw)
-        # Docks by name (reparent into this main window)
-        for name in ("dock_workspace", "dock_plugins", "dock_settings", "dock_log"):
+            temp = loader.load(f)
+            if temp is None:
+                raise RuntimeError("Failed to load UI")
+        finally:
+            f.close()
+        # temp is a QMainWindow instance created from the .ui
+        try:
+            # Apply geometry and top-level properties
             try:
-                dw = w.findChild(QDockWidget, name)
-                if dw:
-                    area = Qt.LeftDockWidgetArea if name in ("dock_workspace", "dock_plugins") else (Qt.RightDockWidgetArea if name == "dock_settings" else Qt.BottomDockWidgetArea)
-                    self.addDockWidget(area, dw)
+                self.setObjectName(temp.objectName())
             except Exception:
-                continue
-        # Expose widgets by attribute for logic (from loaded root)
-        self.ws_path = w.findChild(QLineEdit, "ws_path")
-        self.ws_browse = w.findChild(QPushButton, "ws_browse")
-        self.plugins_path = w.findChild(QLineEdit, "plugins_path")
-        self.plugins_browse = w.findChild(QPushButton, "plugins_browse")
-        self.btn_load_ws = w.findChild(QPushButton, "btn_load_ws")
-        self.btn_save_cfg = w.findChild(QPushButton, "btn_save_cfg")
-        self.btn_run = w.findChild(QPushButton, "btn_run")
-        self.filter_text = w.findChild(QLineEdit, "filter_text")
-        self.filter_phase = w.findChild(QComboBox, "filter_phase")
-        self.list_plugins = w.findChild(QListWidget, "list_plugins")
-        self.sp_timeout2 = w.findChild(QSpinBox, "sp_timeout2")
-        self.chk_sandbox2 = w.findChild(QCheckBox, "chk_sandbox2")
-        self.sp_parallel2 = w.findChild(QSpinBox, "sp_parallel2")
-        self.sp_timeout = w.findChild(QSpinBox, "sp_timeout")
-        self.chk_sandbox = w.findChild(QCheckBox, "chk_sandbox")
-        self.sp_parallel = w.findChild(QSpinBox, "sp_parallel")
-        self.txt_log = w.findChild(QPlainTextEdit, "txt_log")
+                pass
+            try:
+                self.setWindowTitle(temp.windowTitle())
+            except Exception:
+                pass
+            try:
+                self.setGeometry(temp.geometry())
+            except Exception:
+                pass
+            # Menubar/Statusbar
+            try:
+                from PySide6.QtWidgets import QMenuBar, QStatusBar
+                mb = temp.findChild(QMenuBar)
+                if mb:
+                    self.setMenuBar(mb)
+                sb = temp.findChild(QStatusBar)
+                if sb:
+                    self.setStatusBar(sb)
+            except Exception:
+                pass
+            # Central widget
+            cw = temp.centralWidget()
+            if cw:
+                self.setCentralWidget(cw)
+            # Docks: transfer all docks and restore original state to preserve positions
+            docks = temp.findChildren(QDockWidget)
+            for dw in docks:
+                # Add to some area first; we'll restore precise layout below
+                try:
+                    self.addDockWidget(Qt.LeftDockWidgetArea, dw)
+                except Exception:
+                    pass
+            try:
+                state = temp.saveState()
+                self.restoreState(state)
+            except Exception:
+                pass
+        finally:
+            try:
+                temp.deleteLater()
+            except Exception:
+                pass
+        # Expose commonly used widgets by name
+        self._ui_loaded = self
+        self.ws_path = self.findChild(QLineEdit, "ws_path")
+        self.ws_browse = self.findChild(QPushButton, "ws_browse")
+        self.plugins_path = self.findChild(QLineEdit, "plugins_path")
+        self.plugins_browse = self.findChild(QPushButton, "plugins_browse")
+        self.btn_load_ws = self.findChild(QPushButton, "btn_load_ws")
+        self.btn_save_cfg = self.findChild(QPushButton, "btn_save_cfg")
+        self.btn_run = self.findChild(QPushButton, "btn_run")
+        self.filter_text = self.findChild(QLineEdit, "filter_text")
+        self.filter_phase = self.findChild(QComboBox, "filter_phase")
+        self.list_plugins = self.findChild(QListWidget, "list_plugins")
+        self.sp_timeout2 = self.findChild(QSpinBox, "sp_timeout2")
+        self.chk_sandbox2 = self.findChild(QCheckBox, "chk_sandbox2")
+        self.sp_parallel2 = self.findChild(QSpinBox, "sp_parallel2")
+        self.sp_timeout = self.findChild(QSpinBox, "sp_timeout")
+        self.chk_sandbox = self.findChild(QCheckBox, "chk_sandbox")
+        self.sp_parallel = self.findChild(QSpinBox, "sp_parallel")
+        self.txt_log = self.findChild(QPlainTextEdit, "txt_log")
         # Menus/actions
-        self.actOpenWorkspace = w.findChild(QAction, "actOpenWorkspace")
-        self.actSelectPluginsDir = w.findChild(QAction, "actSelectPluginsDir")
-        self.actSaveConfig = w.findChild(QAction, "actSaveConfig")
-        self.actRun = w.findChild(QAction, "actRun")
-        self.menuTheme = w.findChild(QMenu, "menuTheme")
+        self.actOpenWorkspace = self.findChild(QAction, "actOpenWorkspace")
+        self.actSelectPluginsDir = self.findChild(QAction, "actSelectPluginsDir")
+        self.actSaveConfig = self.findChild(QAction, "actSaveConfig")
+        self.actRun = self.findChild(QAction, "actRun")
+        self.menuTheme = self.findChild(QMenu, "menuTheme")
 
     def _wire_menu_from_ui(self):
         # Connect actions
@@ -166,7 +190,15 @@ def _wire_menu_from_ui(self):
             self.actRun.triggered.connect(self._run)
         # Populate theme menu
         self.m_theme = self.menuTheme
-        self._populate_theme_menu()
+        if not self.m_theme:
+            try:
+                mb = self.menuBar() if hasattr(self, 'menuBar') else None
+                if mb:
+                    self.m_theme = mb.findChild(QMenu, "menuTheme")
+            except Exception:
+                self.m_theme = None
+        if self.m_theme:
+            self._populate_theme_menu()
 
     def _wire_logic(self):
         # Buttons (defensive: only connect when widgets are present)
@@ -228,6 +260,8 @@ def _apply_theme_file(self, path: Path):
 
     def _populate_theme_menu(self):
         # Scan themes/ at repo root
+        if not getattr(self, "m_theme", None):
+            return
         self.m_theme.clear()
         try:
             root = Path(__file__).resolve().parents[3]
@@ -240,8 +274,11 @@ def _populate_theme_menu(self):
                 act = self.m_theme.addAction(qss.name)
                 act.triggered.connect(lambda _=False, p=qss: self._apply_theme_file(p))
         except Exception:
-            act = self.m_theme.addAction("Themes load error")
-            act.setEnabled(False)
+            try:
+                act = self.m_theme.addAction("Themes load error")
+                act.setEnabled(False)
+            except Exception:
+                pass
 
     # ---------- Workspace and Plugins ----------
     def _browse_ws(self):