Skip to content

Commit 9ed96c6

Browse files
committed
Correction de l'appel à compare_lock_payloads dans les helpers CLI
1 parent 78b129c commit 9ed96c6

2 files changed

Lines changed: 15 additions & 2 deletions

File tree

Ui/Cli/helpers.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -397,8 +397,10 @@ def cache_rebuild_lock(workspace: Path, payload: dict[str, Any]) -> str:
397397
return _cache_rebuild_lock(workspace, payload)
398398

399399

400-
def compare_lock_payloads(left: dict[str, Any], right: dict[str, Any]) -> bool:
401-
return _compare_lock_payloads(left, right)
400+
def compare_lock_payloads(
401+
left: dict[str, Any], right: dict[str, Any], return_diff: bool = False
402+
) -> bool | tuple[bool, list[str]]:
403+
return _compare_lock_payloads(left, right, return_diff=return_diff)
402404

403405

404406
def default_lock_path(workspace: Path) -> Path:

tests/test_lock_comparison.py

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,16 @@
11
import pytest
22
from Core.Locking import compare_lock_payloads
3+
from Ui.Cli.helpers import compare_lock_payloads as wrapper_compare_lock_payloads
4+
5+
def test_wrapper_compare_lock_payloads_with_diff():
6+
"""Test that the CLI helper wrapper correctly handles return_diff."""
7+
lock_a = {"dependencies": {"numpy": "1.24.0"}}
8+
lock_b = {"dependencies": {"numpy": "1.25.0"}}
9+
10+
ok, diffs = wrapper_compare_lock_payloads(lock_a, lock_b, return_diff=True)
11+
assert ok is False
12+
assert any("dependencies.numpy: 1.24.0 -> 1.25.0" in d for d in diffs)
13+
314

415
def test_compare_lock_payloads_functional_equivalence():
516
"""Test that comparison ignores build_id but detects critical changes."""

0 commit comments

Comments
 (0)