refactor: remove ensure_tools methods in bcasl and engine to use directly ensure_tools from utils.py

Signed-off-by: Samuel Amen Ague <ague.samuel27@gmail.com>

Author: raidos23

.gitignore

@@ -1,185 +1,37 @@
-# Byte-compiled / optimized / DLL files
+# Byte-compiled
 __pycache__/
-*.py[cod]
-*$py.class
-*.tar.gz
 # C extensions
 *.so
-.codex
 # Swap/backup files
 *.swp
 *.bak
 .codex
 # Distribution / packaging
-.Python
 build/
 dist/
 *.egg-info/
 .eggs/
 *.egg
-MANIFEST
-.installed.cfg
-sdist/
-develop-eggs/
-downloads/
-eggs/
-lib/
-lib64/
-parts/
-var/
-wheels/
-pip-wheel-metadata/
-share/python-wheels/
-
-# PyInstaller
-*.manifest
-*.spec
-
-# Installer logs
-pip-log.txt
-pip-delete-this-directory.txt
-
-# Unit test / coverage reports
-htmlcov/
-.tox/
-.nox/
-.coverage
-.coverage.*
-.cache
-nosetests.xml
-coverage.xml
-*.cover
-*.py,cover
-.hypothesis/
-.pytest_cache/
-
-# Translations
-*.mo
-*.pot
-
-# Django
-*.log
-local_settings.py
-db.sqlite3
-db.sqlite3-journal
-.codex
-# Flask
-instance/
-.webassets-cache
-
-# Scrapy
-.scrapy
-
-# Sphinx documentation
-docs/_build/
-
-# PyBuilder
-target/
-
-# Jupyter Notebook
-.ipynb_checkpoints
-
-# IPython
-profile_default/
-ipython_config.py
-bcasl.yml
-# pyenv
-.python-version
-
-# pipenv
-#Pipfile.lock
-
-# PEP 582
-__pypackages__/
-
-# Celery
-celerybeat-schedule
-celerybeat.pid
-
-# SageMath
-*.sage.py
-
 # Environments
 .env
 .venv
 env/
 venv/
 ENV/
-env.bak/
-venv.bak/
-
 # mypy
 .mypy_cache/
 .dmypy.json
 dmypy.json
-
 # Pyre
 .pyre/
-
-# pytype
-.pytype/
-
-# Cython debug symbols
-cython_debug/
-
 # IDEs / Editors
-.directory
 .idea/
 .vscode/
-.spyderproject
-.spyproject
-.ropeproject
 .qtcreator/
-
-# OS files
-.DS_Store
-Thumbs.db
-ehthumbs.db
-Desktop.ini
-
-# mkdocs
-/site
-
-# Security files
-*.p12
-*.pfx
-*.key
-*.pem
-certificates/
-
-# PyCompiler ARK specific
-experimental_file/
-cloc
-error_logs/
-logs/
-crash_reports/
-work_notes.txt
-output/
-compiled/
-artifacts/
-*.exe
-*.app
-*.dmg
-*.pkg
-*.deb
-*.rpm
-config.json
-config.yaml
-config.toml
-user_preferences.json
-
-clean_venv_duplicates.py
-force_clean_venv_files.py
-Licence_Injector.py
-sys
-.blackbox/
-.blackboxrules
-.kombai
-.pref/
-.qodo
-
 # Temporary files
-temp/
 tmp/
-*.tmp
-prototype/
+#todo
+todo.md
+TODO.md
+todo/
+TODO/

pycompiler_ark/Core/Compiler/engine_runner.py

@@ -34,6 +34,7 @@
 from pathlib import Path
 from typing import Any, Callable, Optional
 
+from pycompiler_ark.Core.utils.ensure_tools import ensure_tools
 from pycompiler_ark.Ui import output
 
 # BuildContext lives in engine_sdk; imported here so callers of this module
@@ -355,10 +356,10 @@ def sys_deps_manager(self):
         if on_stdout:
             on_stdout(f"⚙️ Environnement : {env_display}")
 
-        if hasattr(engine_instance, "ensure_tools_installed"):
-            if not engine_instance.ensure_tools_installed(
-                bridge, stop_signal=stop_signal
-            ):
+        required_tools = getattr(engine_instance, "required_tools", {}) or {}
+        if required_tools.get("python") or required_tools.get("system"):
+            result = ensure_tools(required_tools, stop_signal=stop_signal, gui=bridge)
+            if not result.ok:
                 if stop_signal and stop_signal():
                     return _failure("Compilation annulee par l'utilisateur.")
                 return _failure(

pycompiler_ark/Core/engine/base.py

@@ -19,6 +19,8 @@
 from dataclasses import dataclass
 from typing import TYPE_CHECKING, Callable, Optional
 
+from pycompiler_ark.Ui import output
+
 if TYPE_CHECKING:
     from pycompiler_ark.Core.engine.build_context import BuildContext
 
@@ -92,12 +94,6 @@ def resolve_engine_meta(engine_or_cls: object) -> EngineMeta:
         author=str(getattr(engine_or_cls, "author", "") or ""),
     )
 
-
-def _tools_stage_message(stage: str, fr: str, en: str) -> tuple[str, str]:
-    prefix = f"[tools:{stage}] "
-    return prefix + fr, prefix + en
-
-
 class CompilerEngine:
     """
     Base class for a pluggable compilation engine.
@@ -251,17 +247,6 @@ def required_tools(self) -> dict[str, list[str]]:
         """
         return {"python": [], "system": []}
 
-    def ensure_tools_installed(
-        self, gui, stop_signal: Optional[Callable[[], bool]] = None
-    ) -> bool:
-        """
-        Check if all required tools are installed, and install missing ones.
-        Delegates to the universal ensure_tools utility.
-        """
-        from pycompiler_ark.Core.utils.ensure_tools import ensure_tools
-        res = ensure_tools(self.required_tools, stop_signal=stop_signal, gui=gui)
-        return res.ok
-
     def get_log_prefix(self, file_basename: str) -> str:
         """
         Return a log prefix string for the engine's compilation messages.

pycompiler_ark/bcasl/Base.py

@@ -108,26 +108,6 @@ def required_tools(self) -> dict[str, list[str]]:
         """
         return {"python": [], "system": []}
 
-    def ensure_tools(
-        self,
-        stop_signal: Callable[[], bool] | None = None,
-        log_cb: Callable[[str], None] | None = None,
-    ) -> bool:
-        """Vérifie et installe les outils requis déclarés dans required_tools.
-
-        Délègue vers l'utilitaire universel Core.utils.ensure_tools.
-        Retourne True si tous les outils sont disponibles, False sinon.
-        """
-        tools = self.required_tools
-        if not tools.get("python") and not tools.get("system"):
-            return True
-        from pycompiler_ark.Core.utils.ensure_tools import (
-            ensure_tools as _ensure_tools,
-        )
-
-        result = _ensure_tools(tools, stop_signal=stop_signal, log_cb=log_cb)
-        return result.ok
-
     def on_pre_compile(self, ctx: PreCompileContext) -> None:
         """Méthode à surcharger par le plugin."""
         raise NotImplementedError

pycompiler_ark/bcasl/executor.py

@@ -25,6 +25,7 @@
 
 from pycompiler_ark.bcasl.PreCompileContext import PreCompileContext
 
+from pycompiler_ark.Core.utils.ensure_tools import ensure_tools
 from pycompiler_ark.bcasl.Base import (
     BCASL_PLUGIN_REGISTER_FUNC,
     BcPluginBase,
@@ -310,7 +311,8 @@ def _run_plugin_sequential(
     tools = getattr(plg, "required_tools", {})
     if tools.get("python") or tools.get("system"):
         log_cb = getattr(ctx, "_log_cb", None)
-        if not plg.ensure_tools(stop_signal=stop_requested, log_cb=log_cb):
+        result = ensure_tools(tools, stop_signal=stop_requested, log_cb=log_cb)
+        if not result.ok:
             _add_report_item(
                 report,
                 plugin_id=plg.meta.id,