fix(gui): bloquer la compilation si BCASL echoue (fail-fast)

Author: raidos23

Core/Compiler/__init__.py

@@ -199,6 +199,56 @@ def _run_bcasl_before_compile(self, on_done) -> None:
                 pass
 
 
+def _bcasl_report_allows_compile(self, report) -> bool:
+    """Return True when BCASL pre-compile report allows compilation to continue."""
+    # Sécurité fail-fast: si BCASL plante/échoue, on bloque la compilation.
+    try:
+        if report is None:
+            log_i18n_level(
+                self,
+                "error",
+                "BCASL a échoué ou n'a pas retourné de rapport. Compilation bloquée.",
+                "BCASL failed or returned no report. Compilation blocked.",
+            )
+            return False
+
+        if isinstance(report, dict):
+            status = str(report.get("status", "")).strip().lower()
+            if status in {"disabled", "skipped"}:
+                return True
+            if "ok" in report:
+                ok = bool(report.get("ok"))
+                if not ok:
+                    log_i18n_level(
+                        self,
+                        "error",
+                        "BCASL a signalé un échec. Compilation bloquée.",
+                        "BCASL reported a failure. Compilation blocked.",
+                    )
+                return ok
+            return True
+
+        if hasattr(report, "ok"):
+            ok = bool(getattr(report, "ok"))
+            if not ok:
+                log_i18n_level(
+                    self,
+                    "error",
+                    "BCASL a signalé des erreurs plugins. Compilation bloquée.",
+                    "BCASL reported plugin errors. Compilation blocked.",
+                )
+            return ok
+    except Exception:
+        log_i18n_level(
+            self,
+            "error",
+            "Erreur lors de la validation du rapport BCASL. Compilation bloquée.",
+            "Error while validating BCASL report. Compilation blocked.",
+        )
+        return False
+    return True
+
+
 def compile_all(self) -> None:
     """
     Slot connected to the compile button.
@@ -400,6 +450,9 @@ def _after_bcasl(_report=None) -> None:
                 "Compilation cancelled before start (BCASL phase).",
             )
             return
+        if not _bcasl_report_allows_compile(self, _report):
+            self.set_controls_enabled(True)
+            return
         try:
             log_i18n_level(
                 self,
@@ -800,6 +853,10 @@ def _after_bcasl(_report=None) -> None:
             )
             result["value"] = False
             return
+        if not _bcasl_report_allows_compile(self, _report):
+            self.set_controls_enabled(True)
+            result["value"] = False
+            return
         ok = False
         try:
             ok = _do_start()

tests/test_compiler_smoke.py

@@ -100,14 +100,47 @@ def fake_start(_self, _engine, files):
         compiler_module, "_get_main_process", lambda: DummyMainProcess()
     )
     monkeypatch.setattr(
-        compiler_module, "_run_bcasl_before_compile", lambda _self, cb: cb(None)
+        compiler_module,
+        "_run_bcasl_before_compile",
+        lambda _self, cb: cb({"status": "disabled"}),
     )
 
     compiler_module.compile_all(gui)
 
     assert captured.get("files") == [str(entry)]
 
 
+def test_compile_all_stops_when_bcasl_report_is_failure(test_workspace, monkeypatch) -> None:
+    entry = test_workspace / "main.py"
+    assert set_entrypoint(str(test_workspace), "main.py") is True
+
+    gui = DummyGUI()
+    gui.workspace_dir = str(test_workspace)
+    gui.python_files = [str(entry)]
+    gui.selected_files = [str(entry)]
+
+    captured = {"started": False}
+
+    def fake_start(_self, _engine, _files):
+        captured["started"] = True
+
+    monkeypatch.setattr(compiler_module, "_start_compilation_queue", fake_start)
+    monkeypatch.setattr(compiler_module, "create", lambda _eid: DummyEngine())
+    monkeypatch.setattr(
+        compiler_module, "_get_main_process", lambda: DummyMainProcess()
+    )
+    monkeypatch.setattr(
+        compiler_module,
+        "_run_bcasl_before_compile",
+        lambda _self, cb: cb({"ok": False, "error": "bcasl failed"}),
+    )
+
+    compiler_module.compile_all(gui)
+
+    assert captured["started"] is False
+    assert gui._controls_enabled is True
+
+
 def test_compilation_thread_warns_when_live_streams_are_unavailable() -> None:
     thread = CompilationThread(program="python", args=["-V"])
     warnings: list[str] = []