VSCode extension: add support for bpp-lsp's -j/--threads

Connected to 6d721b5

The VSCode extension now has a configurable option for the number of worker
threads in the language server.

Both this feature and the earlier-added support for -b (target-bash-version)
are now gated behind bpp-lsp version number checks.

- -b was introduced in v0.8.0. If the version number < 0.8.0, the extension
will ignore the configured option for -b, and show a warning to the user
- -j will be introduced in the upcoming v0.8.11. As with -b, if the version
number isn't high enough, the option is ignored and warning is displayed

Author: rail5

vscode/CHANGELOG.md

@@ -1,5 +1,14 @@
 # Change Log
 
+## [0.8.1]
+- Added support for bpp-lsp's `-j`/`--threads` option to specify the number of worker threads in the language server
+  - This option allows users to configure the performance of the language server by specifying how many worker threads it should use for processing requests.
+  - Users can set this option in the VSCode extension settings under `Bash++: Language Server: Thread Count`.
+  - By default, the language server will use a number of threads equal to the number of CPU cores available.
+- Gated `-b` and `-j` options behind a check for the language server's version to ensure compatibility
+  - `-b` was introduced in bpp-lsp v0.8.0, and `-j` was introduced in bpp-lsp v0.8.11
+  - If the language server does not support these options, the extension will fall back to default behavior without them, and will show a startup warning to the user
+
 ## [0.8.0]
 
 - Added support for bpp-lsp's `-b`/`--target-bash` option to specify the target Bash version for compilation

vscode/extension.js

@@ -1,9 +1,52 @@
 const vscode = require('vscode');
 const { LanguageClient, TransportKind } = require('vscode-languageclient');
+const { execFile } = require('child_process');
+const { promisify } = require('util');
+const execFileAsync = promisify(execFile);
 
 /** @type {LanguageClient | null} */
 let client = null;
 
+/**
+ * `bpp-lsp --version` outputs:
+ * Bash++ Language Server x.y.z
+ * .. more lines
+ * 
+ * So here, we just call `--version`,
+ * and scan the first line for [0-9]+\.[0-9]+\.[0-9]+
+ * 
+ * We return it as an array of 3 elements: [major, minor, patch]
+ * If the version cannot be determined, we return [0, 0, 0]
+ */
+async function getServerVersion(serverPath) {
+	try {
+		const { stdout } = await execFileAsync(serverPath, ['--version']);
+		const firstLine = stdout.split('\n')[0];
+		const versionMatch = firstLine.match(/(\d+)\.(\d+)\.(\d+)/);
+		if (versionMatch) {
+			return versionMatch.slice(1, 4).map(num => parseInt(num, 10));
+		}
+	} catch (err) {
+		vscode.window.showInformationMessage('Warning: Unable to determine Bash++ Language Server version. Some features may not work as expected. Please ensure the server is installed and accessible.');
+	}
+	return [0, 0, 0];
+}
+
+/**
+ * Function to compare two version arrays [major, minor, patch]
+ * Returns true if versionA >= versionB
+ */
+function isVersionGreaterOrEqual(versionA, versionB) {
+	for (let i = 0; i < 3; i++) {
+		if (versionA[i] > versionB[i]) {
+			return true;
+		} else if (versionA[i] < versionB[i]) {
+			return false;
+		}
+	}
+	return true; // versions are equal
+}
+
 async function stopClient() {
 	if (client) {
 		await client.stop();
@@ -32,6 +75,10 @@ async function startClient(context) {
 			return;
 		}
 
+		// First: get the server version to determine which features are supported
+		const serverVersion = await getServerVersion(serverPath);
+		console.log(`Bash++ Language Server version: ${serverVersion.join('.')}`);
+
 		const args = ['--stdio'];
 
 		if (!config.get('showWarnings', true)) {
@@ -51,8 +98,24 @@ async function startClient(context) {
 		});
 
 		// Get the target bash version
-		const targetBashVersion = config.get('targetBashVersion', '5.2');
-		args.push(`-b${targetBashVersion}`);
+		// Note: '-b' was introduced in 0.8.0
+		if (isVersionGreaterOrEqual(serverVersion, [0, 8, 0])) {
+			const targetBashVersion = config.get('targetBashVersion', '5.2');
+			args.push(`-b${targetBashVersion}`);
+		} else {
+			vscode.window.showInformationMessage('Bash++ Language Server version does not support target bash version configuration. Please upgrade to bpp-lsp 0.8.0 or later to use this feature.');
+		}
+
+		// Get the thread count for the language server
+		// Note: '-j' was introduced in 0.8.11
+		if (isVersionGreaterOrEqual(serverVersion, [0, 8, 11])) {
+			const threadCount = config.get('threadCount', 0);
+			if (threadCount > 0) {
+				args.push(`-j${threadCount}`);
+			}
+		} else {
+			vscode.window.showInformationMessage('Bash++ Language Server version does not support thread count configuration. Please upgrade to bpp-lsp 0.8.11 or later to use this feature.');
+		}
 
 		const serverOptions = {
 			run: {